Forkconsolidation/smarre2022 aug #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This selects correct version of FormatMessageA and FormatMessageW.
There already were code to handle this, but it requires connection to be pending.
Original always converted to true.
Patched with rdp2tcp.patch from the rdp2tcp-20181203.zip file, shared by Artur Zaprzała (https://github.com/ArturZaprzala) as posted in FreeRDP/FreeRDP#935.
New patch is effectively the same as the original. Mainly indent changes. # Conflicts: # client/channel.c # common/print.c # server/Makefile.mingw32 # server/tunnel.c
…orkconsolidation/Smarre2022Aug Notes: 1) Though I agree with using the "char width neutral" functions of the win32api, I rejected FormatMessageA -> FormatMessage for consistency. There are other references to *A() functions, which really should be made neutral. Especially CreateProcessA() in server/process.c, which can include a path to a command, that will be limited to ASCII only path components. 2) I am retaining my extension for reverse tunnelling, and the associated fixes for race conditions. I acknowledge that changes related to "pending" data, may have taken away the necessity for the changes. I'll review again down the track. # Conflicts: # client/controller.c # server/Makefile.mingw32 # server/events.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.