Vulkan: release upload buffer after init copy #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
changed the title
This reverts commit 1659c20.
csyonghe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan init‑upload memory retention — per‑buffer staging kept alive
In Vulkan createBuffer(initData) the backend created a per‑buffer upload/staging buffer (m_uploadBuffer) and kept it as a member, so host memory scaled with every buffer ever initialized. The fix uses a local upload buffer and releases it after the copy completes (with flushAndWait() to match D3D’s semantics), eliminating the persistent host‑memory footprint.