[codex] fix string highlighting after static assert#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Slang TextMate grammar leak where a quoted diagnostic string containing a qualified call-like token, such as
_Texture::SampleCmpLevel(...), could cause subsequent code to remain highlighted as part of the string/meta scope.Root Cause
The
meta.qualified.type.call.slanglookahead could scan through quoted text afterShape.dimensions, find_Texture::SampleCmpLevel(inside the string literal, and incorrectly keep the qualified-call scope active. The string rules also had no end-of-line fallback, which made leaks more visible when a string scope failed to close cleanly.Changes
Validation
syntaxes/slang.tmLanguage.jsonwithConvertFrom-Json.static_assertstring closes, the followingifis scoped askeyword.control.slang, escaped quotes still work, and unterminated strings do not leak into the next line.