Skip to content

Commit 00bf550

Browse files
compile-perf: fix Windows runner — add bash to PATH, use python3
The release sweep uses shell: bash steps but doesn't go through common-setup (no build needed), so Git Bash wasn't on PATH. Also replace bare 'python' with 'python3' throughout both workflows — Windows doesn't have a 'python' alias by default.
1 parent a39e49c commit 00bf550

2 files changed

Lines changed: 16 additions & 10 deletions

File tree

.github/workflows/compile-perf-nightly.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ jobs:
121121
args=(--slangc "$SLANGC" --label "$LABEL" --out "$RESULTS/daily" --samples "$SAMPLES" --warmup 1)
122122
[ -n "$ONLY" ] && args+=(--only "$ONLY")
123123
# Daily ToT sweep -> perf-results/daily/<label>/results.json
124-
python bench.py "${args[@]}"
124+
python3 bench.py "${args[@]}"
125125
# Stamp meta + rebuild perf-results/tracking/tracking.json
126-
python track.py register --results "$RESULTS" --index "$RESULTS/index.json" \
126+
python3 track.py register --results "$RESULTS" --index "$RESULTS/index.json" \
127127
--label "$LABEL" --commit "$COMMIT" --corpus-sha "$CORPUS_SHA"
128128
129129
- name: Push results
@@ -164,7 +164,7 @@ jobs:
164164
exit 0
165165
fi
166166
cd "$SUITE"
167-
python report.py --results "$RESULTS" --index "$RESULTS/index.json"
167+
python3 report.py --results "$RESULTS" --index "$RESULTS/index.json"
168168
169169
- name: Checkout gh-pages branch
170170
continue-on-error: true
@@ -233,4 +233,4 @@ jobs:
233233
run: |
234234
set -euo pipefail
235235
cd "$GITHUB_WORKSPACE/tools/compile-perf"
236-
python trend.py --results "$GITHUB_WORKSPACE/perf-results"
236+
python3 trend.py --results "$GITHUB_WORKSPACE/perf-results"

.github/workflows/compile-perf-release-sweep.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@ jobs:
4343
group: nvrgfx
4444
labels: [Windows, X64, nvrgfx-perf]
4545
steps:
46+
- name: Add bash to PATH (Windows)
47+
shell: pwsh
48+
run: |
49+
Add-Content -Path $env:GITHUB_PATH -Value "C:\Program Files\Git\bin"
50+
Add-Content -Path $env:GITHUB_PATH -Value "C:\Program Files\Git\usr\bin"
51+
4652
# No Slang build here — we sweep prebuilt RELEASE binaries. fetch-depth 0
4753
# is needed so fetch_releases.py can read release tags + dates from git.
4854
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
@@ -93,16 +99,16 @@ jobs:
9399
cd "$SUITE"
94100
force=(); [ "$FORCE_ENABLED" = "true" ] && force=(--force)
95101
# Prebuilt slangc for each release, matching THIS runner's platform.
96-
python fetch_releases.py --repo "$GITHUB_WORKSPACE" \
102+
python3 fetch_releases.py --repo "$GITHUB_WORKSPACE" \
97103
--since "$SINCE" --until "$UNTIL" "${force[@]}"
98104
# Sweep every release into the results repo (history baseline).
99-
python sweep.py --index releases/index.json --results "$RESULTS" \
105+
python3 sweep.py --index releases/index.json --results "$RESULTS" \
100106
--samples "$SAMPLES" "${force[@]}"
101107
# Store the release manifest, stamp the runner the history was built on,
102108
# and rebuild the tracking series.
103109
cp releases/index.json "$RESULTS/index.json"
104-
python track.py stamp-runner --results "$RESULTS" --label "release-sweep-$(date -u +%Y-%m-%d)"
105-
python track.py rebuild --results "$RESULTS" --index "$RESULTS/index.json"
110+
python3 track.py stamp-runner --results "$RESULTS" --label "release-sweep-$(date -u +%Y-%m-%d)"
111+
python3 track.py rebuild --results "$RESULTS" --index "$RESULTS/index.json"
106112
107113
- name: Push results
108114
shell: bash
@@ -113,7 +119,7 @@ jobs:
113119
git config user.email "slang-perf-bot@users.noreply.github.com"
114120
git add -A
115121
if git diff --cached --quiet; then echo "no changes"; exit 0; fi
116-
git commit -m "release history resync $(date -u +%Y-%m-%d) (runner $(python "$GITHUB_WORKSPACE/tools/compile-perf/track.py" runner-id))"
122+
git commit -m "release history resync $(date -u +%Y-%m-%d) (runner $(python3 "$GITHUB_WORKSPACE/tools/compile-perf/track.py" runner-id))"
117123
git push
118124
119125
- name: Revoke PAT from perf-results git config
@@ -138,7 +144,7 @@ jobs:
138144
exit 0
139145
fi
140146
cd "$SUITE"
141-
python report.py --results "$RESULTS" --index "$RESULTS/index.json"
147+
python3 report.py --results "$RESULTS" --index "$RESULTS/index.json"
142148
143149
- name: Checkout gh-pages branch
144150
continue-on-error: true

0 commit comments

Comments
 (0)