Skip to content

Commit 70a9aa5

Browse files
Tighten diagnoseConflictingDescriptorHeapStrideOptions doc comment (#11723)
Match the comment to the actual condition: the conflict is between a non-zero explicit -spirv-resource-heap-stride and the unified stride; an explicit stride of 0 selects the same default OpConstantSizeOfEXT path the unified option modifies and is not a conflict.
1 parent 3f03d48 commit 70a9aa5

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

source/slang/slang-emit-spirv.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7310,8 +7310,9 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
73107310
}
73117311

73127312
// Diagnoses the mutually-exclusive `-spirv-resource-heap-stride` / unified-stride option pair:
7313-
// an explicit literal stride and the unified maximum stride contradict, so passing both is an
7314-
// error rather than letting one silently win.
7313+
// a non-zero explicit literal stride and the unified maximum stride contradict, so combining
7314+
// them is an error rather than letting one silently win. An explicit stride of 0 selects the
7315+
// same default `OpConstantSizeOfEXT` path the unified option modifies, so it is not a conflict.
73157316
void diagnoseConflictingDescriptorHeapStrideOptions()
73167317
{
73177318
if (isUnifiedResourceHeapStrideEnabled() &&

0 commit comments

Comments
 (0)