Skip to content

Commit 893f8cc

Browse files
Qualify CONFLICT test comment as non-zero stride (#11723)
Comment-only: the CONFLICT variant uses -spirv-resource-heap-stride 64, and the conflict is specifically with a non-zero explicit stride (explicit 0 selects the same default path and is accepted). Test directives are unchanged.
1 parent b2aeac1 commit 893f8cc

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

tests/spirv/descriptor-heap-unified-stride.slang

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
// Without the flag (control): each heap array carries its own per-type OpConstantSizeOfEXT, no max chain.
1515
//TEST:SIMPLE(filecheck=DEFAULT): -target spirv-asm -entry computeMain -stage compute -capability spvDescriptorHeapEXT
1616

17-
// Conflict: the explicit literal stride and the unified maximum stride are mutually exclusive, so
18-
// passing both is a hard error rather than silently letting one win.
17+
// Conflict: a non-zero explicit literal stride and the unified maximum stride are mutually
18+
// exclusive, so combining them is a hard error rather than silently letting one win. (An explicit
19+
// stride of 0 selects the same default path the unified option modifies and is accepted.)
1920
//DIAGNOSTIC_TEST:SIMPLE(filecheck=CONFLICT): -target spirv-asm -entry computeMain -stage compute -capability spvDescriptorHeapEXT -spirv-resource-heap-stride 64 -spirv-unified-descriptor-heap-stride
2021

2122
// Single resource category: a shader that uses ONLY a constant buffer must STILL advertise the

0 commit comments

Comments
 (0)