Fix mishandling of incoming socket buffer.#2988
Merged
Merged
Conversation
Contributor
|
Thanks for this — it's a non-trivial change to incoming-buffer handling across local/redir/server/tunnel, so it needs careful review and testing before merge. Could you rebase onto current master? Keeping open for review. |
…ening socket not the accepted socket.
notsure2
force-pushed
the
fix-socket-buffer-handling
branch
from
3abcacc to
2ee261f
Compare
Contributor
Author
|
@madeye all cleaned and tied with a bow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous PR on this, I implemented the incoming buffer control wrong.
It should be set on the listening socket, not on the accepted socket.