Fix strip choking on non-binary files; bump Alpine to 3.23 and implement multi-stage build#3029
Open
biliwala wants to merge 3 commits into
Open
Fix strip choking on non-binary files; bump Alpine to 3.23 and implement multi-stage build#3029biliwala wants to merge 3 commits into
biliwala wants to merge 3 commits into
Conversation
- fix strip error
Contributor
|
Thanks — the |
03964d5 to
3c48c26
Compare
Author
|
Rebased on vndroid/master. |
The build logic has been updated to use `scanelf` to identify and target only ELF binaries for stripping, avoiding build failures caused by the `strip` command targeting non-binary scripts like `ss-nat` and `ss-setup`.
…age build - Bump base image from Alpine 3.19 to 3.23 - Implement multi-stage build to reduce image size
3c48c26 to
71b07a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The Alpine Docker build fails with a
strip: ss-setup: file format not recognizederror. This occurs because thestripcommand targets all files in/usr/local/bin, including non-binary scripts such asss-natandss-setup.Solution:
The build logic has been updated to use
scanelfto identify and target only ELF binaries for stripping. This replaces the manual file exclusion method (grep -v) with an automated format check.Improvements: