Skip to content

CMakeLists.txt: Add LANGUAGES option to project variable#3033

Open
bkuhls wants to merge 1 commit into
shadowsocks:masterfrom
bkuhls:cmake_c
Open

CMakeLists.txt: Add LANGUAGES option to project variable#3033
bkuhls wants to merge 1 commit into
shadowsocks:masterfrom
bkuhls:cmake_c

Conversation

@bkuhls

@bkuhls bkuhls commented Apr 4, 2026

Copy link
Copy Markdown

Fixes build with toolchains without c++.

Fixes build with toolchains without c++.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
@madeye

madeye commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thanks. The intent — restrict the project to C so no C++ compiler is required — is good, but set(PROJECT_NAME shadowsocks-libev LANGUAGES C) makes PROJECT_NAME the list shadowsocks-libev;LANGUAGES;C, which only works by accident when later expanded into project(). Please set the languages directly on the project() call instead. Note master's cmake_minimum_required was just bumped to 3.10 (#3034), so a rebase is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants