test: Add LCEVC SEI tests #8209
Conversation
This PR adds LCEVC SEI tests to Shaka Player. It plays an LCEVC SEI content for 6 seconds and checks LCEVCdec public APIs to verify that LCEVC is enabled and LCEVC data was found in SEI.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
Incremental code coverage: 100.00% |
avelad
added
the
component: tests
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
This doesn't appear to be working yet, so I'm converting it to draft status. When GitHub Actions CI is passing, please mark it as ready for review, and then we'll run lab tests again. Thanks! |
I just realized that these failures are actually caused by other PRs that were just recently merged. I'm reverting them now. Then I'll merge main into your PR branch and re-test. Sorry for the confusion! |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
@shaka-bot test |
|
@joeyparrish: Lab tests started with arguments:
|
|
I've just updated the lab devices, so hopefully that will take care of some of those test failures. |
|
"Failed to load LCEVC" on Chromecast Ultra. Maybe those non-Android Cast devices don't support WebGL or something else needed for this? Can this be feature-detected at runtime? If not, you can refuse LCEVC on non-Android Chromecast devices with existing helpers in shaka.util.Platform. I believe we have already discussed "SyntaxError: Unexpected token *" on Tizen elsewhere, which is caused by ES6 features in the LCEVC library. Firefox Windows failures were fixed by #8271, and Safari screenshot failures will be fixed by #8273 when that is merged. Merging those back in from main should resolve those failures. |
|
Converted to draft so I can filter it out of the PR list more easily. Please click "ready for review" when you've updated it and you're ready for us to re-run the lab tests. |
This PR adds LCEVC SEI tests to Shaka Player. It plays an LCEVC SEI content for 6 seconds and checks LCEVCdec public APIs to verify that LCEVC is enabled and LCEVC data was found in SEI.