build: Add shaka namespace types to generated externs

[avelad]

Issue #6762

[avelad]

shaka-player.experimental.debug.externs.js -->

/**
 * @typedef {{
 *   abr: typeof shaka.abr,
 *   ads: typeof shaka.ads,
 *   cast: typeof shaka.cast,
 *   cea: typeof shaka.cea,
 *   config: typeof shaka.config,
 *   dash: typeof shaka.dash,
 *   drm: typeof shaka.drm,
 *   hls: typeof shaka.hls,
 *   lcevc: typeof shaka.lcevc,
 *   media: typeof shaka.media,
 *   msf: typeof shaka.msf,
 *   net: typeof shaka.net,
 *   offline: typeof shaka.offline,
 *   Player: typeof shaka.Player,
 *   polyfill: typeof shaka.polyfill,
 *   queue: typeof shaka.queue,
 *   text: typeof shaka.text,
 *   transmuxer: typeof shaka.transmuxer,
 *   ui: typeof shaka.ui,
 *   util: typeof shaka.util,
 * }}
 * @suppress {duplicate}
 */
var shaka;

shaka-player.dash.externs.js -->

/**
 * @typedef {{
 *   abr: typeof shaka.abr,
 *   cea: typeof shaka.cea,
 *   config: typeof shaka.config,
 *   dash: typeof shaka.dash,
 *   drm: typeof shaka.drm,
 *   lcevc: typeof shaka.lcevc,
 *   media: typeof shaka.media,
 *   net: typeof shaka.net,
 *   Player: typeof shaka.Player,
 *   polyfill: typeof shaka.polyfill,
 *   text: typeof shaka.text,
 *   transmuxer: typeof shaka.transmuxer,
 *   util: typeof shaka.util,
 * }}
 * @suppress {duplicate}
 */
var shaka;

[shaka-bot]

Bundle Size Report for PR #9596

File	HEAD	Base	Diff
controls.css	21.8 KiB (4.7 KiB)	21.8 KiB (4.7 KiB)	0.0 KiB
demo.compiled.debug.js	239.2 KiB (48.2 KiB)	239.3 KiB (48.2 KiB)	-0.1 KiB
demo.compiled.js	239.2 KiB (48.2 KiB)	239.3 KiB (48.2 KiB)	-0.1 KiB
demo.css	169.9 KiB (27.7 KiB)	169.9 KiB (27.7 KiB)	0.0 KiB
locales.js	42.6 KiB (10.6 KiB)	42.6 KiB (10.6 KiB)	0.0 KiB
receiver.compiled.debug.js	143.2 KiB (23.8 KiB)	143.2 KiB (23.8 KiB)	0.0 KiB
receiver.compiled.js	143.2 KiB (23.8 KiB)	143.2 KiB (23.8 KiB)	0.0 KiB
shaka-player.compiled.debug.js	1479.2 KiB (338.0 KiB)	1479.2 KiB (338.0 KiB)	+0.0 KiB
shaka-player.compiled.js	740.5 KiB (239.5 KiB)	740.5 KiB (239.5 KiB)	0.0 KiB
shaka-player.dash.debug.js	1082.9 KiB (252.9 KiB)	1082.9 KiB (252.9 KiB)	+0.0 KiB
shaka-player.dash.js	509.1 KiB (168.6 KiB)	509.1 KiB (168.6 KiB)	0.0 KiB
shaka-player.experimental.debug.js	1867.4 KiB (418.0 KiB)	1867.4 KiB (418.0 KiB)	+0.0 KiB
shaka-player.experimental.js	980.2 KiB (304.0 KiB)	980.2 KiB (304.0 KiB)	0.0 KiB
shaka-player.hls.debug.js	1120.0 KiB (259.1 KiB)	1120.0 KiB (259.1 KiB)	+0.0 KiB
shaka-player.hls.js	547.2 KiB (180.1 KiB)	547.2 KiB (180.1 KiB)	0.0 KiB
shaka-player.ui.debug.js	1806.3 KiB (404.9 KiB)	1806.3 KiB (404.9 KiB)	+0.0 KiB
shaka-player.ui.js	953.7 KiB (296.0 KiB)	953.7 KiB (296.0 KiB)	0.0 KiB

[shaka-bot]

Incremental code coverage: No instrumented code was changed.

[TAhub]

The original issue singles out the shakaNamespaceType typedef in test/test/util/loader.js as something this change should remove the need for.

Some quick searching suggests the same typedef is used in multiple other test files too, such as test/ui/vr_ui_integration.js and test/test/util/manifest_generator.js.

I don't know if we can mark that issue closed until that typedef is refactored out. If you view that as outside of the scope of this particular PR, you could change this to just reference the issue rather than close it.

[avelad]

@TAhub do you want work on that part?

[TAhub]

Sure, I could make a follow-up PR if you want.

[avelad]

Sure, I could make a follow-up PR if you want.

Please!