Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to deployments #615

Merged
merged 59 commits into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
ee08d3a
Pass correct arg
justin808 Jan 23, 2025
c790151
Set args with =
justin808 Jan 23, 2025
8355030
Address deprecation messages
justin808 Jan 23, 2025
f19d79f
Updates to deployment
justin808 Jan 23, 2025
e487791
updates
justin808 Jan 23, 2025
25e9502
Fixed the deployment_id output in the
justin808 Jan 23, 2025
de55983
fixes
justin808 Jan 23, 2025
5240c9b
fixes
justin808 Jan 23, 2025
2a1b9a3
fixes
justin808 Jan 23, 2025
8918cd2
fixes
justin808 Jan 23, 2025
fe262cb
fixes
justin808 Jan 23, 2025
80d841b
fixes
justin808 Jan 23, 2025
084f0d0
fixes
justin808 Jan 23, 2025
cac41c4
Fixed failure to deploy to review app
justin808 Jan 23, 2025
745ca0e
fixes
justin808 Jan 23, 2025
f77a610
fixes
justin808 Jan 23, 2025
87662fa
Updates, fix crash
justin808 Jan 24, 2025
4970fbe
fixes
justin808 Jan 24, 2025
e26cc72
fixes
justin808 Jan 24, 2025
29ade6f
Fixes
justin808 Jan 24, 2025
8db0511
fixes
justin808 Jan 24, 2025
b7a7229
fixes
justin808 Jan 24, 2025
1cff976
fixes
justin808 Jan 24, 2025
6cbdb04
fixes
justin808 Jan 24, 2025
0b15816
fixes
justin808 Jan 24, 2025
ae8a473
fixes
justin808 Jan 24, 2025
e6d5025
fixes
justin808 Jan 24, 2025
444ec85
fixes
justin808 Jan 24, 2025
8041a01
fixes
justin808 Jan 24, 2025
b03b6d7
fixes
justin808 Jan 24, 2025
a12e0d4
fixes
justin808 Jan 24, 2025
98649f2
fixes
justin808 Jan 24, 2025
b2e710a
fixes
justin808 Jan 24, 2025
c54a544
fixes
justin808 Jan 24, 2025
c80ff43
fixes
justin808 Jan 24, 2025
40473cc
fixes
justin808 Jan 25, 2025
038cf8f
fixes
justin808 Jan 25, 2025
c25211f
fixes
justin808 Jan 25, 2025
304e642
fixes
justin808 Jan 25, 2025
4744c76
fixes
justin808 Jan 25, 2025
5c8b3ab
fixes
justin808 Jan 26, 2025
2a51c92
fixes
justin808 Jan 26, 2025
61213b9
fixes
justin808 Jan 26, 2025
e431bdf
fixes
justin808 Jan 26, 2025
895986c
fixes
justin808 Jan 26, 2025
3fe506e
fixes
justin808 Jan 26, 2025
585c02d
fixes
justin808 Jan 26, 2025
c46f595
fixes
justin808 Jan 26, 2025
65c64d1
fixes
justin808 Jan 26, 2025
e96ac82
doc changes
justin808 Jan 26, 2025
2be9c2f
Changes made:
justin808 Jan 26, 2025
5f50639
fixes
justin808 Jan 26, 2025
e0cf883
fixes
justin808 Jan 26, 2025
b27783e
added promotion and other fixes
justin808 Jan 26, 2025
66a4114
fixes
justin808 Jan 26, 2025
3426aca
fix-for-delete
justin808 Jan 26, 2025
92ad3a7
fix-for-delete
justin808 Jan 26, 2025
7d75738
fix-for-delete
justin808 Jan 26, 2025
d5b8b7f
fix-for-delete
justin808 Jan 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .controlplane/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
ARG RUBY_VERSION=3.3.4
FROM registry.docker.com/library/ruby:$RUBY_VERSION-slim as base

# Current commit hash environment variable
ARG GIT_COMMIT
ENV GIT_COMMIT_SHA=${GIT_COMMIT}

# Install packages needed to build gems and node modules
RUN apt-get update -qq && \
apt-get install --no-install-recommends -y build-essential curl git libpq-dev libvips node-gyp pkg-config python-is-python3
Expand Down Expand Up @@ -76,7 +80,3 @@ ENTRYPOINT ["./.controlplane/entrypoint.sh"]
# Default args to pass to the entry point that can be overridden
# For Kubernetes and ControlPlane, these are the "workload args"
CMD ["./bin/rails", "server"]

# Current commit hash environment variable
ARG GIT_COMMIT_SHA
ENV GIT_COMMIT_SHA=${GIT_COMMIT_SHA}
2 changes: 1 addition & 1 deletion .github/actions/deploy-to-control-plane/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ runs:
cpln image docker-login
# Use BUILDKIT_PROGRESS=plain to get more verbose logging of the build
# BUILDKIT_PROGRESS=plain cpflow build-image -a ${{ inputs.app_name }} --commit ${{steps.vars.outputs.sha_short}} --org ${{inputs.org}}
cpflow build-image -a ${{ inputs.app_name }} --commit ${{steps.vars.outputs.sha_short}} --org ${{inputs.org}}
cpflow build-image -a ${{ inputs.app_name }} --commit=${{steps.vars.outputs.sha_short}} --org=${{inputs.org}}
# --cache /tmp/.docker-cache
- name: Deploy to Control Plane
shell: bash
Expand Down
Loading