-
-
Notifications
You must be signed in to change notification settings - Fork 636
Don't lint any git-ignored files #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the ESLint configuration and related dependency handling. In the ESLint config file, two new import statements were added, and the configuration now integrates the project’s Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
55f8ebc
to
3443913
Compare
3443913
to
da03ba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.gitignore (2)
15-16
: Review Duplicatetmp
Directory Patterns
The file now contains both/tmp/
(line 8) andtmp/
(line 15). While this may be intentional to cover temporary directories at different levels, it’s worth verifying if both patterns are needed or if they can be consolidated to avoid redundancy.
45-45
: Minor Formatting Adjustment
The change on this line appears to be a formatting or whitespace adjustment. Ensure that the file maintains consistent formatting throughout.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (5)
.gitignore
(4 hunks)eslint.config.ts
(3 hunks)package.json
(1 hunks)script/convert
(1 hunks)spec/dummy/.gitignore
(0 hunks)
💤 Files with no reviewable changes (1)
- spec/dummy/.gitignore
🚧 Files skipped from review as they are similar to previous changes (3)
- package.json
- script/convert
- eslint.config.ts
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: dummy-app-integration-tests (newest)
- GitHub Check: dummy-app-integration-tests (oldest)
- GitHub Check: build
- GitHub Check: rspec-package-tests (oldest)
- GitHub Check: rspec-package-tests (newest)
🔇 Additional comments (6)
.gitignore (6)
1-1
: Refined.bundle
Pattern Scope
The change from an anchored pattern (likely/.bundle/
) to.bundle/
now ignores any directory named.bundle
regardless of its location in the repository. This is in line with the PR objective of excluding git-ignored files to improve linting performance.
4-4
: Broadening thecoverage
Directory Ignore
Changing the pattern tocoverage/
ensures that any directory named "coverage"—no matter where it appears—is ignored. This better covers various coverage output locations and helps speed up lint operations.
28-28
: Updated Yarn Integrity Ignore
The modified pattern.yarn-integrity
will ignore the file consistently across environments. Confirm that this meets your intended directory structure and build setup.
46-54
: Consolidated Dummy App Ignore Rules
Integrating the dummy app ignore patterns directly into the main.gitignore
streamlines the rules and removes redundancy (notably eliminating the separatespec/dummy/.gitignore
). The inclusion of specific exceptions like!/spec/dummy/log/.keep
is well-managed.
55-60
: Addition of ReScript Build Files Ignore Patterns
These new entries for ReScript build artifacts (e.g.,.merlin
,lib/bs/
,.bsb.lock
,*.res.js
) ensure that generated files from the build process are skipped during linting, which should further improve overall performance.
61-62
: Excluding Generated Files from Linting
The ignore rule for files/folders labeled asgenerated
(tagged with “Generated by ROR FS-based Registry”) is a good addition to prevent unnecessary linting. This aligns with best practices for excluding auto-generated content.
da03ba6
to
783e987
Compare
783e987
to
460b773
Compare
Summary
Avoid linting any files in
.gitignore
to speed up.Pull Request checklist
[ ] Add/update test to cover these changes[ ] Update documentation[ ] Update CHANGELOG fileThis change is
Summary by CodeRabbit
.gitignore
file and refining file ignore patterns for a more consistent development environment..gitignore
file to include additional patterns for ignored files and directories, focusing on temporary files and ReScript build artifacts.