Add InferenceConfigContainer and InferenceSetupConfig for arg-free init#2
Open
shanmugamr1992 wants to merge 1 commit into
Open
Conversation
Introduce a declarative, serializable InferenceSetupConfig (mirroring the inference argparse group) and an InferenceConfigContainer so inference entry points can drive the refactored initialize_megatron() without constructing a training-shaped PretrainConfigContainer. - Add InferenceSetupConfig (megatron/training/config/inference_config.py) with a to_inference_config() mapper that produces the runtime megatron.core.inference.config.InferenceConfig from the built model. - Add InferenceConfigContainer holding only inference-relevant configs. - Add inference_cfg_from_args() / inference_cfg_container_from_args() helpers. - Make get_inference_config_from_model_and_args() delegate to the mapper so the declarative config is the single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a declarative, serializable InferenceSetupConfig (mirroring the inference argparse group) and an InferenceConfigContainer so inference entry points can drive the refactored initialize_megatron() without constructing a training-shaped PretrainConfigContainer.
Add InferenceSetupConfig (megatron/training/config/inference_config.py) with a to_inference_config() mapper that produces the runtime megatron.core.inference.config.InferenceConfig from the built model.
Add InferenceConfigContainer holding only inference-relevant configs.
Add inference_cfg_from_args() / inference_cfg_container_from_args() helpers.
Make get_inference_config_from_model_and_args() delegate to the mapper so the declarative config is the single source of truth.
I, the PR author, have personally reviewed every line of this PR.
What does this PR do ?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.