Skip to content

Feature/cli installer #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shannah merged 127 commits into from
Dec 30, 2025
Merged

Feature/cli installer #347

shannah merged 127 commits into from
Dec 30, 2025

Conversation

@shannah
Copy link
Owner

@shannah shannah commented Dec 17, 2025

No description provided.

shannah added 12 commits December 24, 2025 09:39
@shannah
feat: Add support for CLI commands in installer via jdeploy.commands
95e81c8
@shannah
feat: Add parsing of command specs from package.json
6c4152c
@shannah
feat: Persist package.json jdeploy.commands into jdeploy bundle metadata
4e45ff2
@shannah
feat: Add CLI launcher based on system property or env var check (Mac…
538e198 
…Bundler.java)
@shannah
feat: Add helper to conditionally create CLI launcher on macOS
dfe898c
@shannah
feat: Parse commands from package.json in NPMPackageVersion
7246765
@shannah
feat: Support multiple CLI commands from package metadata
08ce6ba
@shannah
feat: Make addToPath testable and refactor Linux CLI script writer
402d315
@shannah
feat: Add Windows CLI command wrapper generation and PATH update
fb42433
@shannah
fixed builds for shared and installer
3b6bcc0
@shannah
Reverted accidental removal of bin/jdeploy
0867c58
@shannah
fix: Removed unnecessary embedding of package-info into package service
77f491b
@shannah shannah force-pushed the feature/cli-installer branch from 8b19032 to 77f491b Compare December 24, 2025 17:39
shannah added 17 commits December 24, 2025 09:52
@shannah
refactor: split CLI install options into launcher vs commands and wir…
4b41b8c 
…e UI
@shannah
refactor: extract CommandSpecParser and delegate parsing from NPMPack…
2b38590 
…ageVersion and JDeployProject
@shannah
refactor: introduce CliInstallerConstants and use across installers a…
ffc8534 
…nd bundler
@shannah
feat: MacBundler add BundlerSettings-aware maybeCreateCliLauncher in …
b54e22b 
…MacBundlerCliLauncherTest
@shannah
feat: add CliCommandInstaller interface (CliCommandInstaller)
d13c0da
@shannah
feat: add LinuxCliCommandInstaller to manage CLI scripts and PATH
ee69862
@shannah
feat: add MacCliCommandInstaller to manage CLI scripts and PATH
216fef6
@shannah
feat: refactor Windows CLI installer and delegate wrapper creation to…
9ec9ec3 
… WindowsCliCommandInstaller
@shannah
refactor: Main delegate CLI install logic to LinuxCliCommandInstaller…
3f42a05 
… in Main
@shannah
refactor: UninstallWindows delegate CLI cleanup to WindowsCliCommandI…
eabeab4 
…nstaller
@shannah
test: add CommandSpecParserTest with comprehensive parsing tests
698785c
@shannah
test: add NPMPackageVersionTest to validate getCommands behavior
dbca095
@shannah
test: simplify assertions and stabilize CliCommandInstallerIntegratio…
5832692 
…nTest
@shannah
chore: select Mockito version by JDK profile and add JUnit5/Mockito deps
14c71ba
@shannah
enh: Add configurable binDir for CLI installer and persist in metadata
136759e
@shannah
updated build command
3046f28
@shannah
feat: add installLauncher method to LinuxCliCommandInstaller
b24af7d
shannah added 28 commits December 29, 2025 08:24
@shannah
fix: getBinDir() on Mac/Linux should be parent directory of command l…
dbf1dd1 
…ine path
@shannah
test: use specific launcher path for commandLinePath in CLI installer…
ed8ea3f 
… tests
@shannah
feat: Consolidated linux Add cli-commands to include cli launcher
eec3b82 
This keeps UI less cluttered, at the cost of a little bit less fine-grained control.  E.g. the user
has to install both the CLI launcher and CLI commands or neither.
@shannah
fix: mark commandLineSymlinkCreated in LinuxCliCommandInstaller
3b8aa06
@shannah
feat: update LinuxCliCommandInstaller to add symlink and metadata han…
2574e9e 
…dling
@shannah
test: setInstallCliLauncher(false) in LinuxCliCommandInstallerTest
a700ac0
@shannah
test: skip DefaultInstallationFormCheckboxTest when headless environment
5c3f079
@shannah
feat: Added integration test for installer for commands project
9c6243c
@shannah
feat: add WindowsPESubsystemModifier and its unit tests
a91e983
@shannah
feat: add maybeCreateCliLauncher to WindowsBundler2 and use it in bun…
3309276 
…dler
@shannah
feat: InstallWindows add CLI launcher copy and tmp CLI finder
a82c974
@shannah
fix: use actual CLI launcher when installing commands in InstallWindows
91d2590
@shannah
feat: add Windows CLI launcher creation, metadata and uninstall handling
54c7553
@shannah
fix: correct SUBSYSTEM_FIELD_OFFSET in WindowsPESubsystemModifier and…
9db2f6a 
… tests
@shannah
fix: Fixed windows CLI commands generation
7a983ea 
- WindowsBundler no longer generates cli exe.  Intsead the installer just copies the gui exe on install and sets the PE status header to console.
- Fixed duplicate command generation in both Main and InstallWindows.
@shannah
feat: update WindowsCliCommandInstaller to handle Git Bash PATH and a…
b34136d 
…dd constant
@shannah
fix: improve Git Bash PATH handling in WindowsCliCommandInstaller
63e040f
@shannah
feat: support MSYS shell wrapper in WindowsCliCommandInstaller
93e893c
@shannah
fix: delete both .cmd and extensionless shell wrappers in WindowsCliC…
4ba42bc 
…ommandInstaller
@shannah
test: add Windows Git Bash path and script creation tests to CliComma…
75dd3c5 
…ndInstallerIntegrationTest
@shannah
docs: update cli-commands-in-installer RFC with Git Bash/MSYS2 path a…
6de9c2f 
…nd uninstall notes
@shannah
fix: improve Git Bash PATH handling in WindowsCliCommandInstaller
134c37a
@shannah
test: update CliCommandInstallerIntegrationTest to use mockHome and a…
089dcf3 
…ssert .bashrc creation
@shannah
test: update UnixPathManager tests and behavior for PATH env optimiza…
2a5c6a9 
…tions
@shannah
test: update DefaultInstallationFormCheckboxTest for Linux coupling
77407e1
@shannah
test: mock home directory in CliCommandInstallerIntegrationTest
5e16c78
@shannah
test: mock home directory in Linux and Mac CLI installer tests
35e4c0e
@shannah
test: run Linux-only assumptions in DefaultInstallationFormCheckboxTest
848eeff
@shannah shannah merged commit ea978aa into master Dec 30, 2025
10 checks passed
@shannah shannah deleted the feature/cli-installer branch December 30, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shannah