Improve select field value handling and null checks#144
Merged
Conversation
PHP 8 made count() throw TypeError on non-Countable arguments, which the @ suppression operator no longer hides. Dataface_FormTool_select::pushValue was calling @count() on $element->getValue(), which can be a string when the element is an HTML_QuickForm_hidden (e.g. via ShortRelatedRecordForm). Branch on is_array() before counting, and return the scalar value as-is otherwise (treating null/empty string as null to preserve the previous "no value" semantics). Fixes #143 https://claude.ai/code/session_01RCVV3MQ8NYE21NfbQVvHzn
Owner
Author
|
Fixes #143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the value handling logic in the select form tool to improve robustness and clarity when processing field values, particularly for array and null cases.
Key Changes
@count($val)>0to explicitis_array($val)check for better type safety and removed error suppression operatorcount($val) > 0 ? $val[0] : nullnullonly when appropriate instead of always returningnullImplementation Details
The changes improve the distinction between three cases:
This prevents unintended null returns for valid scalar values while maintaining backward compatibility for array and null cases.
https://claude.ai/code/session_01RCVV3MQ8NYE21NfbQVvHzn