dag: support term-level if-then-else (ite)#2
Merged
Merged
Conversation
OL1V3R's DAG paniced on 'ite' (unsupported term operation), erroring out on the one eval instance whose ite survives z3 preprocessing (protected_divide). Add Node::Ite(cond, a, b): cond is a boolean node, the branches are terms. The condition is true iff its score is exactly 1 -- satisfied atoms score exactly one() and the wedge-mean/vee-max aggregation preserves it in both Rational and f64 -- so the branch select is exact and reuses the scores the bottom-up pass already computes. Both branches are evaluated (the linear pass touches every node) and Ite selects; the untaken branch is harmlessly discarded. Purely additive: no non-ite formula builds an Ite node, so all other instances are byte-identical. protected_divide now solves sat across all seeds; the other five ite instances are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OL1V3R's DAG paniced on 'ite' (unsupported term operation), erroring out on the one eval instance whose ite survives z3 preprocessing (protected_divide).
Add Node::Ite(cond, a, b): cond is a boolean node, the branches are terms. The condition is true iff its score is exactly 1 -- satisfied atoms score exactly one() and the wedge-mean/vee-max aggregation preserves it in both Rational and f64 -- so the branch select is exact and reuses the scores the bottom-up pass already computes. Both branches are evaluated (the linear pass touches every node) and Ite selects; the untaken branch is harmlessly discarded.
Purely additive: no non-ite formula builds an Ite node, so all other instances are byte-identical. protected_divide now solves sat across all seeds; the other five ite instances are unaffected.