fix: add special handling for user wallet error and don't log to sentry

[premiumjibles]

Summary by CodeRabbit

• Refactor
  • Improved error message handling to provide more consistent and user-friendly error messages across transaction operations (send and swap functionality).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
shapeshift-agentic	Ready	Preview	Comment	Dec 8, 2025 0:01am

[coderabbitai]

📝 Walkthrough

Walkthrough

Three executor utility files are updated to centralize error message handling by importing and using getUserFriendlyErrorMessage utility function, replacing ad-hoc error message construction across sendExecutor and swapExecutor. An import path in main.tsx is corrected to use the module alias.

Changes

Cohort / File(s)	Change Summary
Error Message Centralization apps/agentic-chat/src/utils/sendExecutor.ts, apps/agentic-chat/src/utils/swapExecutor.ts	Replaced custom error message construction in catch blocks with centralized getUserFriendlyErrorMessage utility function; sendExecutor uses 'Send' context, swapExecutor uses 'Approval' and 'Swap' contexts. Import of utility function added to both files.
Import Path Correction apps/agentic-chat/src/main.tsx	Changed import path for isUserCancellation from relative path to module alias @/utils/walletErrors; Sentry beforeSend error filtering logic preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

• Refactoring follows a consistent, repetitive pattern across sendExecutor and swapExecutor
• Error message construction is straightforward delegation to utility function
• No complex logic changes or control flow modifications
• Verify that error contexts ('Send', 'Approval', 'Swap') are appropriate and match intended user-facing messaging

Possibly related PRs

• fix: a bunch of bug fixes #135: Also modifies swapExecutor.ts error and log handling; may have overlapping changes or dependencies
• fix: wallet connect not signing properly #102: Modifies swapExecutor.ts and updates function signatures; potential integration point with this refactoring

Poem

🐰 In the warren of code, errors once scattered wide,
Now bundled in one utility, side by side,
No more custom messages in each catch block's sight,
A hop toward clarity—our chatbot's just right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: refactoring error handling to use centralized user-friendly messages and filtering user-cancellation errors from Sentry logging.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wallet-errors

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 54b2ced and b7a38c9.

📒 Files selected for processing (6)

• .claude/agents/react-19-knowledge.md (1 hunks)
• .claude/commands/react-review.md (1 hunks)
• apps/agentic-chat/src/main.tsx (2 hunks)
• apps/agentic-chat/src/utils/sendExecutor.ts (2 hunks)
• apps/agentic-chat/src/utils/swapExecutor.ts (3 hunks)
• apps/agentic-chat/src/utils/walletErrors.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

apps/agentic-chat/src/utils/swapExecutor.ts (1)

apps/agentic-chat/src/utils/walletErrors.ts (1)

• getUserFriendlyErrorMessage (23-28)

apps/agentic-chat/src/main.tsx (1)

apps/agentic-chat/src/utils/walletErrors.ts (1)

• isUserCancellation (5-21)

apps/agentic-chat/src/utils/sendExecutor.ts (1)

apps/agentic-chat/src/utils/walletErrors.ts (1)

• getUserFriendlyErrorMessage (23-28)

🔇 Additional comments (12)

.claude/commands/react-review.md (1)

22-50: React 19 categories and checklist align well with best practices.

The critical issues (lines 22–30), performance issues, and best-practice violations map cleanly to React 19 semantics and complement the companion knowledge document. The output format (lines 52–88) is clear and actionable for developers.

.claude/agents/react-19-knowledge.md (5)

1-90: Comprehensive and technically accurate React 19 feature reference.

The documentation of new features (use(), useActionState, useOptimistic, useFormStatus, ref-as-prop, context-as-provider, useDeferredValue with initialValue, document metadata, and resource preloading) is well-structured and aligns with official React 19 guidance.

---

200-360: Rules of React and useEffect anti-patterns are clear and comprehensive.

The "Rules of React" section correctly addresses component purity, hook rules, and immutability. The anti-patterns section thoroughly covers the five common mistakes (data transformation, caching, state reset, event handling, chained effects) with concrete examples. All guidance aligns with React 19 best practices.

---

386-464: Memoization guidance balances React Compiler capabilities with practical scenarios.

The section correctly notes that the React Compiler handles most memoization, while providing clear guidance on when manual memo, useMemo, and useCallback remain necessary. The anti-patterns (lines 451–464) flag common mistakes like objects in dependency arrays and hooks in loops.

---

586-622: Breaking changes and TypeScript migration guidance is accurate.

The table of removed/deprecated APIs (lines 590–600) and TypeScript-specific changes (lines 604–612, ref callback no-implicit-returns, useRef requires argument) correctly reflect React 19 migration requirements. Error handling changes with onUncaughtError, onCaughtError, and onRecoverableError options are also documented accurately.

---

626-655: Red/yellow/green flag checklist is practical and actionable.

The quick-reference checklist provides a memorable way to identify issues during code review. Red flags cover must-fix items, yellow flags suggest improvements, and green flags highlight good patterns. This tiered approach is well-suited for code review automation and developer guidance.

apps/agentic-chat/src/main.tsx (1)

21-27: LGTM! Clean Sentry filtering implementation.

The beforeSend hook correctly filters out user wallet cancellations from Sentry reporting. This is appropriate since user cancellations are intentional actions, not errors worth tracking.

apps/agentic-chat/src/utils/sendExecutor.ts (1)

37-39: LGTM! Consistent error handling.

The error handling is now unified with the centralized getUserFriendlyErrorMessage utility, providing consistent user-facing messages across send operations.

apps/agentic-chat/src/utils/swapExecutor.ts (1)

41-43: LGTM! Unified error handling for swap operations.

Both executeApproval and executeSwap now use the centralized error utility with appropriate operation labels, ensuring consistent user-facing error messages.

Also applies to: 50-52

apps/agentic-chat/src/utils/walletErrors.ts (3)

1-3: LGTM! Well-defined interface.

The WalletError interface correctly extends Error with an optional code property to support EIP-1193 error codes.

---

23-28: Clean utility function.

The function correctly delegates to isUserCancellation and produces clear, consistent messages. The fallback to String(error) for non-Error types is a good defensive pattern.

---

5-21: Implementation is correct; "expired" messages are intentionally grouped with cancellations for UX simplification.

The EIP-1193 code 4001 check correctly identifies explicit user rejections. The message-based fallback patterns provide good coverage for various wallet implementations.

One note: 'request expired' and 'proposal expired' (lines 17-18) are technically timeout/network scenarios rather than explicit user cancellations. However, grouping them with user rejections in the Sentry filter is reasonable—these errors aren't actionable bugs and suppress noise in monitoring. The same grouping in user-facing messages via getUserFriendlyErrorMessage works for UX, though it slightly conflates two different failure modes. This is a sensible trade-off if simplified messaging is preferred over distinguishing timeout scenarios.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/agentic-chat/src/utils/swapExecutor.ts (1)

38-43: Preserve original error when rethrowing to avoid losing context and classification

Catching error and throwing new Error(getUserFriendlyErrorMessage(...)) improves user-facing messages but discards the original error object (stack, code, and any wallet-specific metadata). That can make debugging harder and may interfere with any higher-level logic (e.g., Sentry filtering or additional isUserCancellation checks) that relies on the original error shape rather than just the message.

Consider a pattern that keeps the original error when possible while still surfacing the friendly message:

   } catch (error) {
-    throw new Error(getUserFriendlyErrorMessage(error, 'Approval'))
+    const message = getUserFriendlyErrorMessage(error, 'Approval')
+    if (error instanceof Error) {
+      // Preserve original error details while updating the message
+      error.message = message
+      throw error
+    }
+    throw new Error(message)
   }

…and similarly for the swap path:

   } catch (error) {
-    throw new Error(getUserFriendlyErrorMessage(error, 'Swap'))
+    const message = getUserFriendlyErrorMessage(error, 'Swap')
+    if (error instanceof Error) {
+      error.message = message
+      throw error
+    }
+    throw new Error(message)
   }

This keeps user-friendly messaging while retaining the original error instance for logging and classification.

Also applies to: 47-52

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b7a38c9 and b8bff62.

📒 Files selected for processing (3)

• apps/agentic-chat/src/main.tsx (1 hunks)
• apps/agentic-chat/src/utils/sendExecutor.ts (2 hunks)
• apps/agentic-chat/src/utils/swapExecutor.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• apps/agentic-chat/src/main.tsx
• apps/agentic-chat/src/utils/sendExecutor.ts

🧰 Additional context used

🧬 Code graph analysis (1)

apps/agentic-chat/src/utils/swapExecutor.ts (1)

apps/agentic-chat/src/utils/walletErrors.ts (1)

• getUserFriendlyErrorMessage (23-28)

🔇 Additional comments (1)

apps/agentic-chat/src/utils/swapExecutor.ts (1)

6-6: Centralizing wallet error messaging via getUserFriendlyErrorMessage looks good

Importing getUserFriendlyErrorMessage from @/utils/walletErrors keeps swap error handling consistent with send/other executors and aligns with the PR goal of centralizing wallet error UX.