Add support for comments after section headers (closes #1259)#1260
Merged
sharkdp merged 1 commit intosharkdp:masterfrom Oct 6, 2020
Merged
Add support for comments after section headers (closes #1259)#1260sharkdp merged 1 commit intosharkdp:masterfrom
sharkdp merged 1 commit intosharkdp:masterfrom
Conversation
Owner
|
Thank you very much for this contribution. I'm okay with merging this (even though I usually like to stay close to the upstream repo). But it would be great if we could add a test for the INI syntax in a separate PR first before merging this (see #1213 for details). |
There's no canonical definition of what's the INI syntax, but Python's `ConfigParser` supports comments after section headers: ```ini [section] ; comment ```
YtvwlD
force-pushed
the
ini-section-comment
branch
from
0b0b438 to
6b2aa05
Compare
Owner
|
Thank you for the update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no canonical definition of what's the INI syntax, but Python's
ConfigParsersupports comments after section headers:I also put a PR in upstream (clintberry/sublime-text-2-ini#29), but there have been no merges for a few years.
Also, we already have a modified version here, so a change upstream doesn't take effect.