Fix pager spawn under QEMU user-mode emulation #3531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OctopusET
force-pushed
the
fix-pager-spawn-qemu
branch
4 times, most recently
from
036e0c1 to
4a18088
Compare
Author
OctopusET
force-pushed
the
fix-pager-spawn-qemu
branch
from
4a18088 to
3b09a28
Compare
OctopusET
force-pushed
the
fix-pager-spawn-qemu
branch
3 times, most recently
from
f4fcf4a to
d49acdd
Compare
OctopusET
force-pushed
the
fix-pager-spawn-qemu
branch
from
d49acdd to
75c44a1
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEMU user-mode emulation with glibc 2.34+ may return success from posix_spawn even when the child process fails to execute and exits immediately.
It's caused by QEMU's current implementation limitation.
Use try_wait() after spawn to detect this and fall back to stdout.
Related PR: BurntSushi/ripgrep#3248
Failed CI without this PR: https://github.com/OctopusET/bat/actions/runs/18910014240/job/53977874904