Skip to content

Improve changed date parse errors#2055

Closed
KSHITIZ6341 wants to merge 1 commit into
sharkdp:masterfrom
KSHITIZ6341:fd-changed-date-error-fix
Closed

Improve changed date parse errors#2055
KSHITIZ6341 wants to merge 1 commit into
sharkdp:masterfrom
KSHITIZ6341:fd-changed-date-error-fix

Conversation

@KSHITIZ6341

Copy link
Copy Markdown

Summary

  • Improve error reporting for invalid --changed-* date arguments.
  • Keep the parsed time filter context available so parse failures can mention the specific option.
  • Add a regression test for invalid modified-date input.

Validation

  • cargo test

@KSHITIZ6341 KSHITIZ6341 marked this pull request as ready for review July 5, 2026 13:55
@tmccombs

tmccombs commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

How does this compare to #2054 ?

@KSHITIZ6341

Copy link
Copy Markdown
Author

How does this compare to #2054 ?

Thanks for taking a look. I’m going to close this PR since #2054 is the better place to continue: it was opened first, already has maintainer feedback, and covers the same underlying issue.

The only pieces from this PR that may still be useful are the date-shaped-input guard . I’ll follow along on #2054 instead.

@KSHITIZ6341 KSHITIZ6341 closed this Jul 7, 2026
@KSHITIZ6341 KSHITIZ6341 deleted the fd-changed-date-error-fix branch July 7, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants