Skip to content

Make compilation infallible in bytecode_interpreter where possible #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2025
Merged

Make compilation infallible in bytecode_interpreter where possible #752

merged 2 commits into from
Jul 13, 2025

Conversation

@rben01
Copy link
Contributor

@rben01 rben01 commented Jul 12, 2025

compile_expression and compile_define_variable were actually infallible — the only errors they could have returned were from calling themselves.

sharkdp
sharkdp approved these changes Jul 13, 2025
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sharkdp sharkdp merged commit 32ad734 into sharkdp:master Jul 13, 2025
17 checks passed
@Goju-Ryu Goju-Ryu mentioned this pull request Jul 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rben01 @sharkdp