Add normalized RGB values, e.g, 0.1,0.2,0.3, parsing#316
Open
phqb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need a CLI tool to display RGB colors from normalized format which is used in GLSL shaders code. Then I came across this fantastic tool.
The
parse_numeric_rgb()in this repo parses RGB values asdoubleand always divides them by 225 before constructingColor.This PR add a
parse_numeric_rgb_normalized()in which if RGB values are all in range [0,1], then they are considered normalized and used as-is to constructColor.parse_numeric_rgb_normalized()has higher precedence thanparse_numeric_rgb()to workaround the ambiguous values like0.01 0.01 0.01could be a rounding error of black color. I think makingparse_numeric_rgb()parse values asu8solves this ambiguity problem, but it is not backward compatible and breaks test cases.