Skip to content

fix: incorrect upload-artifact destination directory; Add right-click item lookup function on Huiji Wiki #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: cn
Choose a base branch
from

Conversation

YLTai
Copy link

@YLTai YLTai commented Sep 27, 2024

Changes

This PR primarily addresses the issue of the incorrect upload-artifact destination directory.

  1. .github/workflows/build.yml:

    • Changed the upload-artifact destination directory from InventoryTools/bin/Release/InventoryTools to InventoryTools/bin/Release/InventoryToolsCN.
  2. InventoryTools/Services/RightClickService.cs:

    • Added a new right-click menu option "Open in FFXIV-CN HuijiWiki".
    • Fixed the URL concatenation issue to ensure that the item name is correctly encoded in the URL.

Additional Note

感谢作者在适配工作上的努力!尽管作者已使国际服插件基本适配国服,但仍有一些细节与国服不完全兼容,例如市场价格查询的区服选择、右键查询功能以及本地化翻译等。考虑到这些问题的开发难度相对较低,且前期适配开发人员较少,我希望能直接与您讨论这些适配工作的具体细节。期待您的回复!

YLTai added 3 commits September 28, 2024 05:19
…nation directory from 'InventoryTools' to 'InventoryToolsCN'.

- Added a new option in the RightClickService to search for items on the FFXIV-CN HuijiWiki.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant