Fix calculation of CAP #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @chird - thank's so much for submitting this. Since this is a routine copied from SPC's version, do you have a reference showing the cap calculation change is better or incorrect? Thanks! I also may be able to double check with SPC. |
Author
|
Hi @wblumberg. Do you mean a scientific paper reference? In daily business, I noticed that the CAP values are strange. With my change the values become a realistic difference between virtual temperatures. But I have to admit that I don't know my reference for the CAP definition anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue
#216
Changes
Changes calculation of CAP inside the
parcelxfunction. It is now the difference between the virtual temperature of the parcel and the profile.