Add FirstLogin column to database and profile #1234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to turn off noclip on timer restart, disabled by default u.u I used to use a separate plugin I made for this, but figured it should be in the main plugin itself as a cvar instead. Since adding as a cvar, may as well see if it is wanted upstream.
shavit-misc Add cvar UnNoclipOnRestart (shavitush#1232)
Edge case causing this change, but if style cookies are disabled on a server, no reason to save it.
disable setting style cookie if style cookies are disabled (shavitush#1233)
Startzone speed limit flexibility (shavitush#1219)
|
Would sqlite need a separate query using |
|
Added sqlite handling |
|
Working great! |
|
New users confirmed working |
rtldg
reviewed
Apr 18, 2025
addons/sourcemod/scripting/include/shavit/sql-create-tables-and-migrations.sp
Outdated
Show resolved
Hide resolved
rtldg
reviewed
Apr 18, 2025
addons/sourcemod/scripting/include/shavit/sql-create-tables-and-migrations.sp
Outdated
Show resolved
Hide resolved
rtldg
pushed a commit
that referenced
this pull request
Apr 19, 2025
fix FirstLogin query for sqlite fix statsmenu query oopsie teehee :3 sql-create-tables-and-migrations.sp - fix queries for sqlite Simplify firstlogin column initialization
|
merged by 3d0cd96 |
mourningsickness
added a commit
to KawaiiClan/bhoptimer
that referenced
this pull request
Apr 19, 2025
Add FirstLogin to database and profile (shavitush#1234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a "First Login" stat, complimenting the "Last Login" stat.
How it is calculated:
New User
New user joins -> Current time (same as how "Last Login" is set on first connect)
Migration for existing user:
Has times on server -> Oldest time's timestamp
Does not have times on server -> Last login
Does not have times on server and last login == 0 -> Current time (time of migration)
In my opinion, this is the best way to handle these cases, but feel free to suggest otherwise. Unfortunately we don't have any other metrics to populate existing users' data, but hopefully these are pretty close :^(
The best time to plant a tree is 10 years ago, the second best time is right now.