Skip to content

ci: Update Python version and gcovr version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

ci: Update Python version and gcovr version #13

merged 3 commits into from
Apr 17, 2025

Conversation

shawngao-org
Copy link
Owner

@shawngao-org shawngao-org commented Apr 17, 2025

  • Upgraded Python version from 3.8 to 3.12.7
  • Upgraded gcovr version from 5.0 to 8.3
  • Fixed the sign processing logic in the string tool

Summary by Sourcery

Update Python and gcovr versions, and improve sign processing logic in string parsing

Bug Fixes:

  • Corrected sign processing logic in integer parsing to handle positive and negative signs more robustly

CI:

  • Upgraded Python version to 3.12.7 in GitHub Actions workflow
  • Updated gcovr installation to version 8.3

- Upgraded Python version from 3.8 to 3.12.7
- Upgraded gcovr version from 5.0 to 8.3
- Fixed the sign processing logic in the string tool
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This pull request updates the Python version to 3.12.7 and the gcovr version to 8.3 in the CI configuration, and fixes the sign processing logic in the string tool.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the Python and gcovr versions in the CI workflow.
  • Changed Python version from 3.8 to 3.12.7.
  • Updated gcovr version from 5.0 to 8.3.
.github/workflows/build.yml
Fixed the sign processing logic in the string tool.
  • Modified the logic to correctly handle '+' and '-' signs.
  • Ensured that the index is set correctly after processing the sign.
src/string/string_tools.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shawngao-org - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The conditional logic for the sign processing in parse_int could be simplified.
  • Consider adding a comment explaining why gcovr was upgraded to version 8.3.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- Remove unused state parameters in test functions
- Optimize the way some test cases are written to improve readability
- Fixed memory leak in linked_list_tools.c
- Update function declaration and use const to modify immutable parameters
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@shawngao-org shawngao-org merged commit 881ea23 into main Apr 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant