This repository was archived by the owner on May 13, 2026. It is now read-only.
fix(sensor): use UnitOfVolumeFlowRate enum for UOMs 130, 143, 144#122
Merged
Conversation
UOM_FRIENDLY_NAME entries 130/143/144 stored string literals
("L/h", "gpm", "gph") which fail _check_volume_flow_rate_uom's
`UOM_FRIENDLY_NAME.get(uom) in UnitOfVolumeFlowRate` check — the
StrEnum `in` test matches enum members, not values. Result:
sensors with these UOMs had VOLUME_FLOW_RATE device_class
stripped to None and consequently no state_class.
Switching to UnitOfVolumeFlowRate.LITERS_PER_HOUR /
GALLONS_PER_MINUTE / GALLONS_PER_HOUR matches the fix that
landed in core PR #169017.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"L/h"f-string,"gpm","gph") forUnitOfVolumeFlowRate.LITERS_PER_HOUR/GALLONS_PER_MINUTE/GALLONS_PER_HOURinUOM_FRIENDLY_NAMEentries 130/143/144.VOLUME_FLOW_RATEdevice class (and the derivedstate_class) for sensors with these UOMs.Why
sensor.py:_check_volume_flow_rate_uomvalidates the unit viaUOM_FRIENDLY_NAME.get(uom) in UnitOfVolumeFlowRate. Theincheck on aStrEnummatches enum members, not values, so the literals failed and the device class was stripped toNone. Mirrors the equivalent fix in core PR home-assistant/core#169017.Test plan
device_class: volume_flow_rateand a non-nullstate_class.pre-commit run --all-filesclean.test_sensor.pyis migrated.🤖 Generated with Claude Code