Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-email): disable default component style #100

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

shellscape
Copy link
Owner

@shellscape shellscape commented Dec 16, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR add disableDefaultStyle which will allow an author to skip rendering any default styles that are applied to components. This is handy when trying to use classes or tailwind to override default styling.

This also removes the default value of _blank from Link as most clients automatically remove the target attribute, and those which do not override any values present.

@shellscape shellscape force-pushed the feat/jsx-email/disable-default-style branch from 188eb0d to 17765e3 Compare December 16, 2023 14:48
@shellscape shellscape force-pushed the feat/jsx-email/disable-default-style branch from 17765e3 to 164c6ae Compare December 16, 2023 14:50
Copy link
Contributor

@wladpaiva wladpaiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shellscape shellscape force-pushed the feat/jsx-email/disable-default-style branch from 1f8b9cc to 6389ddb Compare December 16, 2023 17:32
@shellscape shellscape merged commit 2a23bff into main Dec 16, 2023
2 checks passed
@shellscape shellscape deleted the feat/jsx-email/disable-default-style branch December 16, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants