Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-email): assert comma color function notation for Tailwind #101

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

shellscape
Copy link
Owner

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: Fixes #97

Description

This issue fixes #97 by applying a post processor to generated CSS in the Tailwind component, and enforces use of comma separated notation for color functions, as many prominent email clients don't support other notation styles. https://www.caniemail.com/features/css-rgb/

Copy link
Collaborator

@lordelogos lordelogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always how i've written RGB anyways.
I never switched to the space syntax but I can see why it's poorly supported (space separated values are relatively modern)

@shellscape shellscape force-pushed the fix/jsx-email/assert-comma-colors branch from a3444af to 9a8ceaa Compare December 17, 2023 16:55
@shellscape shellscape force-pushed the fix/jsx-email/assert-comma-colors branch from 9a8ceaa to f8c8a99 Compare December 17, 2023 17:01
@shellscape shellscape merged commit dc8ded9 into main Dec 17, 2023
2 checks passed
@shellscape shellscape deleted the fix/jsx-email/assert-comma-colors branch December 17, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind styles not applied on gmail
2 participants