Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailwind): add prefix to production class names #111

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

affanshahid
Copy link
Contributor

Component / Package Name: jsx-email (Tailwind)

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
resolves #110

Description

This PR adds a prefix to the class names generated by the class compiler transformer. This is to ensure that the class names generated, which may begin with a number, do not need to be escaped in the generated CSS, thus increasing compatibility with gmail clients

@lordelogos
Copy link
Collaborator

Thanks for this PR.

This is ready to go @shellscape

@lordelogos lordelogos requested review from lordelogos and removed request for lordelogos December 26, 2023 08:23
@lordelogos lordelogos merged commit 8ebea3c into shellscape:main Dec 26, 2023
2 checks passed
@affanshahid affanshahid deleted the fix/tailwind-prod-prefix branch December 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind production stylesheet not working with gmail
2 participants