Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-email): improve preview speed, support file create and delete again #253

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

shellscape
Copy link
Owner

@shellscape shellscape commented Dec 2, 2024

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR does a bunch:

  • re-enables template file creation and deletion in the preview app
  • speeds up the preview initialization and hmr substantially
  • preview app uses the hash router now, to ease burden for deployed preview apps
  • removes the dependency on @jsx-email/app-preview. the preview app is now copied to the package before publishing. the value of having a separate package was slowly disappearing, and with the latest change it became clear that we had to do version checking from jsx-email to make sure the preview app package was on a minimum version. that would have created more burden for users. the package size purists won't be happy with the increase in size of the main package, especially those not using the preview, but overall it's a better DX

@shellscape shellscape force-pushed the fix/jsx-email/preview-refactor-speed branch 2 times, most recently from 9101971 to dd69735 Compare December 2, 2024 17:56
@shellscape shellscape force-pushed the fix/jsx-email/preview-refactor-speed branch from dd69735 to 4bd783e Compare December 2, 2024 18:13
@shellscape shellscape merged commit ae2fad5 into main Dec 2, 2024
5 checks passed
@shellscape shellscape deleted the fix/jsx-email/preview-refactor-speed branch December 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant