Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx-email): QrCode component #93

Merged
merged 10 commits into from
Dec 21, 2023
Merged

Conversation

Connorbelez
Copy link
Contributor

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR adds a new feature/component. A QR code which is buffered into a dataURL and passed as the src for a regular img component. sample usage:
import { QrCode } from 'jsx-email';

const Email = () => {
return (

);
};

@shellscape shellscape changed the title QR code feature feat(jsx-email): QrCode component Dec 12, 2023
@shellscape
Copy link
Owner

Looks like there's a linting error that snuck in upstream. I'll get that fixed today, and update your branch.

@lordelogos
Copy link
Collaborator

@Connorbelez Thank you for this PR 👏🏽

@shellscape This is ready to go🚀

@shellscape shellscape merged commit 1bbfded into shellscape:main Dec 21, 2023
2 checks passed
@shellscape
Copy link
Owner

@Connorbelez thanks for submitting this!

@shellscape
Copy link
Owner

@Connorbelez apparently the API for qrcode is different when in Node versus when in the browser. Very odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants