chore: release main - #186
Conversation
|
Claude finished @shepherdjerred's task in 1m 17s —— View job Review CompleteTodo List
Review FindingsThis is a release-please automated PR for Critical Issues1. Changelog contains commits from other packages (packages/bun-decompile/CHANGELOG.md) The changelog incorrectly includes changes that belong to the
These entries should be removed from the bun-decompile changelog. 2. Vague commit messages violate conventional commits (packages/bun-decompile/CHANGELOG.md)
These should have descriptive commit messages like:
Design Issues3. Duplicate changelog entries (packages/bun-decompile/CHANGELOG.md) Lines 9-10 and 12-13 contain duplicate feature entries:
This suggests the commits were duplicated or rebased incorrectly. 4. Version bump appropriateness The 0.1.0 → 0.2.0 bump is semantically correct (minor version for new features), but the changelog quality undermines confidence in what's actually being released. The vague commit messages make it difficult to verify that no breaking changes are hidden in the "stuff" and "batch" commits. RecommendationsBefore merging this release:
Note: Since this is an automated release-please PR, you may need to either:
|
31d13bc to
56280f6
Compare
|
Claude finished @shepherdjerred's task in 1m 24s —— View job Review CompleteTodo List
Review FindingsThis is a release-please automated PR for Critical Issues1. Changelog contains commits from other packages (packages/bun-decompile/CHANGELOG.md:8, 20) The changelog incorrectly includes changes that belong to the
Impact: Users installing bun-decompile v0.2.0 will see a changelog claiming features that don't exist in the package. Major Issues2. Vague commit messages violate conventional commits (packages/bun-decompile/CHANGELOG.md:14, 19)
Impact: Impossible to understand what changed without reading the actual code diffs. Minor Issues3. Duplicate changelog entries (packages/bun-decompile/CHANGELOG.md:9-10, 12-13) Two sets of identical entries:
Impact: Suggests Git history issues (rebasing/cherry-picking) and makes the changelog confusing. RecommendationsBefore merging this release:
Since this is automated by release-please, you have two options: Option A: Manual changelog edit (quickest)
Option B: Fix release-please configuration (proper fix)
Option C: Accept and document (if urgent)
Version Bump AssessmentThe 0.1.0 → 0.2.0 bump is semantically appropriate (minor version for new features), but the changelog quality makes it difficult to verify there are no breaking changes hidden in the vague commits. |
|
@claude can you make a PR to address the feedback |
|
Claude finished @shepherdjerred's task in 1m 39s —— View job Changelog Cleanup CompleteTodo List
SummaryI've cleaned up the Changes MadeRemoved cross-package commits:
Removed duplicate entries:
Fixed vague commit messages:
Next StepsThe changelog fix is committed locally (commit Option 1: Push manually git fetch origin
git checkout release-please--branches--main
git pull
# The commit should already be there, or you can cherry-pick it:
# git cherry-pick 846e14ab
git push origin release-please--branches--mainOption 2: Apply the changes manually |
|
@claude can you make a PR to address the feedback |
|
Claude finished @shepherdjerred's task in 1m 20s —— View job Addressing Changelog FeedbackTodo List
SummaryCleaned up the Changes Made
The changelog now only contains entries relevant to |
|
Claude finished @shepherdjerred's task in 1m 14s —— View job PR Review CompleteTodo List
Review FindingsThis is a release-please automated PR for Critical Issues1. Changelog contains commits from other packages ( The changelog incorrectly includes changes that belong to the
Impact: Users installing bun-decompile v0.2.0 will see a changelog claiming features that don't exist in this package. Major Issues2. Vague commit messages (
These violate conventional commit best practices and make it impossible to understand what changed without reading the actual code diffs. Minor Issues3. Duplicate changelog entries ( Two sets of identical entries:
This suggests Git history issues (rebasing/cherry-picking) and clutters the changelog. Version Bump AssessmentThe 0.1.0 → 0.2.0 bump is semantically appropriate (minor version for new features). The version changes in RecommendationsBefore merging this release, manually edit
Decision❌ Do not approve - The changelog quality issues need to be addressed before release.
|
- Remove cross-package entries (multiplexer commits) - Remove duplicate entries for CLI and npm publishing - Fix vague commit messages with descriptive text Co-authored-by: Jerred Shepherd <shepherdjerred@users.noreply.github.com>
shepherdjerred
added
autorelease: tagged
autorelease: pending
and removed
autorelease: pending
autorelease: tagged
labels
shepherdjerred
added
autorelease: pending
autorelease: tagged
and removed
autorelease: tagged
autorelease: pending
labels
* chore: release main * fix(bun-decompile): clean up changelog for v0.2.0 release - Remove cross-package entries (multiplexer commits) - Remove duplicate entries for CLI and npm publishing - Fix vague commit messages with descriptive text Co-authored-by: Jerred Shepherd <shepherdjerred@users.noreply.github.com> --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Jerred Shepherd <shepherdjerred@users.noreply.github.com>
…earch (#1271) * feat(scout-for-lol): web app names, pagination, inline editing & typeahead Improve the authenticated dashboard (packages/app): - Show guild name in the workspace header (reuses guild.listManageable) - Resolve Discord IDs to names everywhere via a new discord.resolveUsers batch + serializer enrichment; audit page uses a useDiscordNames hook - Cache the real Riot ID (gameName#tagLine) on Account with a 24h refresh (fetch-on-demand, await-on-null/background-on-stale) and show it in the account table; resolves schema TODO #186 - Cursor-paginate subscriptions, competitions and the audit log with a reusable LoadMore + useInfiniteQuery; fix a pre-existing off-by-one in the listPlayers cursor (used the peeked overflow id, dropping a row per page boundary) and add a pagination integration test - Move the light/dark/system theme picker into a proper navbar; add a "Report a bug" support link (Discord invite) - Full-scope inline editing on the player detail page: rename, link/unlink Discord, add/edit/delete account (new player.updateAccount mutation) - Typeahead comboboxes (Radix popover) for Riot ID and Discord user across the add/invite/admin flows, backed by riot.searchKnownAccounts, riot.resolveRiotId and discord.searchMembers Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(scout-for-lol): navbar dropdown, hide guild id, 3-source Riot search, drop Admin tab Round 2 of web-app polish (packages/app), addressing demo feedback: - Navbar: brand "Scout" + "Guilds" on the left; an @username dropdown on the right holding the theme selector, "Report a bug", and "Sign out" (new components/user-menu.tsx on the Popover primitive) - Hide the raw guild snowflake entirely in the workspace header — show only the guild name - Riot ID typeahead now has three suggestion sources: our own self-healing SummonerIndex (new table; populated on confirmed Riot resolutions + backfill from Account/PrematchParticipantFact, evicted on a true 404), OP.GG's unofficial search (proxied via its Next.js server action, fail-soft), and Riot's exact resolve to verify/canonicalize the pick. The empty "no results" dropdown is gone (popover only opens with results) - Remove the Admin tab: rename/merge/delete-player, link/unlink Discord, and add/edit/delete/transfer account are now all inline on the player detail page. Deleted admin-tools + the admin form components The official Riot API has no partial-name search; OP.GG searches its own crawled index. The OP.GG proxy is contained to src/lib/riot/opgg-search.ts, never persists data unverified, and degrades to the other two sources if OP.GG changes its build-tied action id. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(scout-for-lol): record round-2 web-app refinements * feat(scout-for-lol): proxy LoL icons, suppress browser autocomplete, OP.GG self-heal Round 3 polish on the Riot ID search: - Suppress Chrome's native form-history dropdown overlapping our combobox (randomized input name + autoCorrect/spellCheck off + 1p/lp ignore) - Show the League profile icon next to each suggestion, proxied through a new session-gated, host-allowlisted GET /api/summoner-icon route so the browser never hotlinks OP.GG's CDN - Make the OP.GG action id self-healing: keep the (deploy-resilient) seed id, and on a stale id best-effort re-discover the current one from OP.GG's webpack chunk bundle (createServerReference ids → probe), gated by a cooldown and fully fail-soft Note: empirically OP.GG keeps old action ids working across deploys, so the seed is fairly resilient on its own; discovery is a best-effort fallback and the field always degrades to our own index + Riot exact-resolve. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(scout-for-lol): record round-3 search polish + OP.GG findings * feat(scout-for-lol): auto-seed the summoner index on startup (incremental) backfillFromExisting now inserts only PUUIDs not already indexed (batched createMany), so it's cheap to re-run, and it runs automatically on backend startup (background, fail-soft) instead of being a manual one-off. The manual script remains for ad-hoc runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(scout-for-lol): address greptile P1/P2 review on search & backfill - opgg-search: make action-id rediscovery non-blocking. A stale cached id now kicks off discovery in the background and the current request fails-soft to [] immediately, instead of awaiting a 30s+ crawl+probe on the autocomplete request path. - resolve/riot-search/add: propagate Riot's canonical gameName/tagLine out of resolveRiotIdToPuuid so resolveRiotIdExact and the subscription add path store/display Riot-canonical casing on first write, not user-typed input. - summoner-index: stream PrematchParticipantFact in id-cursor batches instead of findMany({distinct:[puuid]}), bounding memory on the startup backfill. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(scout-for-lol): log PR #1271 conflict + greptile fixes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style(scout-for-lol): prettier-format subscription-fields + PR #1271 log Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(scout-for-lol): finalize PR #1271 session log Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Jerred Shepherd <claude@sjer.red>
1 participant
🤖 I have created a release beep boop
bun-decompile: 0.2.0
0.2.0 (2026-01-04)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.