docs(dotfiles): refresh remaining language agent skills - #1990
docs(dotfiles): refresh remaining language agent skills#1990shepherdjerred wants to merge 3 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9da58ad4bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9da58ad to
8c15538
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c15538ade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7846fe9 to
957f1e4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 957f1e41ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -l command_status $status | ||
|
|
||
| popd | ||
| or return |
There was a problem hiding this comment.
When the wrapped command is a Fish function that empties the directory stack, or when the original directory becomes unavailable, popd fails and this early return skips the following rm -rf, leaking the temporary directory and its contents. Attempt the cleanup before propagating the popd failure.
Useful? React with 👍 / 👎.
The newly added jvm-helper and lua-helper Research ledgers linked `.../releases/latest`, which returns an HTTP 302 to the actual release page. That fails the repo's prescribed `curl -sI` liveness check even though the target content is live, so the doc's claim that every listed source was live-verified didn't hold up. Resolved each of the 28 `releases/latest` links (curl -L) to its actual release-tag URL and re-verified every replacement returns 200 with a plain `curl -sI` (no redirect-follow). Updated the link labels to name the pinned version instead of "latest" so the text matches the target.
The Fish safe-temp-wrapper example returned early on a failed popd, skipping the following rm -rf. A wrapped function that empties the directory stack, or an original directory that becomes unavailable, makes popd fail, leaking the temp directory and its contents. Run the cleanup unconditionally after popd instead of gating it behind success, and propagate popd's failure status once cleanup is done. Verified with a local Fish repro: the old version leaks the temp dir when the wrapped command empties the dir stack, the fixed version does not.
957f1e4 to
12752fe
Compare
1 participant
Stack created with GitHub Stacks CLI • Give Feedback 💬