sites: include HTTP status + body snippet in data-fetch error#2940
Open
ChrisJr404 wants to merge 1 commit into
Open
sites: include HTTP status + body snippet in data-fetch error#2940ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
When sherlock fails to download the site manifest from MANIFEST_URL,
the previous error told the user only that the URL was bad:
Bad response while accessing data file URL '<url>'.
This made it hard to tell apart a 404 (e.g. user is on an old version
where MANIFEST_URL has since moved), a 5xx (host outage), and a
captive-portal HTML page returned by an upstream proxy. Issue sherlock-project#2924
hit exactly this scenario.
Add the status code, the textual reason, and a 200-character snippet
of the response body so the cause is visible from the error message
alone, without users having to debug with curl.
Closes sherlock-project#2924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2924.
When fetching
MANIFEST_URLfails, the existing error gives the user nothing to go on:That makes it hard to tell whether they hit:
raw.githubusercontent.compath)This includes the HTTP status code, the reason phrase, and the first 200 characters of the response body in the exception message. No behavior change — just makes the error self-diagnosable.