Skip to content

karimsherlock#2945

Open
mountainaddict0 wants to merge 7 commits into
sherlock-project:masterfrom
mountainaddict0:master
Open

karimsherlock#2945
mountainaddict0 wants to merge 7 commits into
sherlock-project:masterfrom
mountainaddict0:master

Conversation

@mountainaddict0
Copy link
Copy Markdown

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Automatic validation of changes

Target F+ Check F- Check
Peerlist ✔️   Pass ✔️   Pass
curseforge ✔️   Pass ✔️   Pass

Copy link
Copy Markdown
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner commit history is ideal, but in either case, please reference comments in review

Comment thread sherlock_project/resources/data.json Outdated
Comment on lines +3301 to +3314
"CurseForge": {
"curseforge": {
"url": "https://www.curseforge.com/members/{}/projects",
"urlMain": "https://www.curseforge.com.",
"urlMain": "https://www.curseforge.com/",
"errorType": "status_code",
"errorCode": 404,
"username_claimed": "blue"
},
"curseforge": {
"url": "https://www.curseforge.com/members/{}/projects",
"urlMain": "https://www.curseforge.com/",
"errorType": "status_code",
"errorCode": 404,
"username_claimed": "blue"
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CurseForge duplicated and name does not match expected case
(Alignment off, but that's more of a code hygiene thing)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Automatic validation of changes

Target F+ Check F- Check
curseforge ✔️   Pass ✔️   Pass
Peerlist ✔️   Pass ✔️   Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants