fix: improve WAF detection for 7Cups, Airliners, and Apple Discussions#2953
Open
Naraka1337 wants to merge 1 commit into
Open
fix: improve WAF detection for 7Cups, Airliners, and Apple Discussions#2953Naraka1337 wants to merge 1 commit into
Naraka1337 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves core WAF detection logic to resolve false positives on several major sites including 7Cups, Airliners, and Apple Discussions.
Changes
Core Engine (sherlock.py)
202 Acceptedstatus codes andx-amzn-waf-actionheaders.window.POW_CHALLENGE_DATAchallenge page.SecurityVerificationAppclass andX-Debugheaders.Testing
WAFverdict for non-existing users (previously reported asClaimed).WAF.ruff checkand all core offline tests viapytest -m "not online". All checks passed.