fix: check query_time instead of response_time_s list in xlsx output#2954
Open
imxde-code wants to merge 1 commit into
Open
fix: check query_time instead of response_time_s list in xlsx output#2954imxde-code wants to merge 1 commit into
imxde-code wants to merge 1 commit into
Conversation
The condition `if response_time_s is None` was always False because response_time_s is initialised as an empty list earlier in the same block. This caused raw None values to be appended to the list for timed-out or errored sites, which pandas then wrote as None cells in the Excel output instead of blank strings. Fix mirrors the correct pattern already used in the CSV output path (lines ~875-877): check the actual query_time value before appending. Fixes sherlock-project#2891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2891
The condition on line 906 checks
if response_time_s is None, butresponse_time_sis initialised as an empty list ([]) on line 896 of the same block — so this check is alwaysFalseand the empty-string fallback is never reached.As a result, when a site's
query_timeisNone(timeout or error), the rawNonegets appended to the list. Pandas then writesNoneinto the Excel cell instead of a blank string, which breaks downstream xlsx processing.Root cause
Fix
This mirrors the pattern already used correctly in the CSV output block (lines ~875–877).
Test plan
sherlock --xlsx <username>— sites that time out now produce blank cells instead ofNone