Skip to content

Non hanging subscriptions and timezonetransitionlists #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Non hanging subscriptions and timezonetransitionlists #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ead52a
Changed so that SendAsync just waits for the repsonse header. Otherwi…
Sep 3, 2019
e6ddc31
When executing on Linux the list of timezonetransitions is significan…
Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ComplexProperties/TimeZones/TimeZoneTransitionGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ internal virtual void InitializeFromAdjustmentRule(AdjustmentRule adjustmentRule
standardPeriodToSet.Id = string.Format(
"{0}/{1}",
standardPeriod.Id,
adjustmentRule.DateStart.Year);
adjustmentRule.DateSTart.ToString("yyyyMMdd"));
standardPeriodToSet.Name = standardPeriod.Name;
standardPeriodToSet.Bias = standardPeriod.Bias;
this.timeZoneDefinition.Periods.Add(standardPeriodToSet.Id, standardPeriodToSet);
Expand All @@ -143,7 +143,7 @@ internal virtual void InitializeFromAdjustmentRule(AdjustmentRule adjustmentRule
daylightPeriod.Id = string.Format(
"{0}/{1}",
TimeZonePeriod.DaylightPeriodId,
adjustmentRule.DateStart.Year);
adjustmentRule.DateSTart.ToString("yyyyMMdd"));
daylightPeriod.Name = TimeZonePeriod.DaylightPeriodName;
daylightPeriod.Bias = standardPeriod.Bias - adjustmentRule.DaylightDelta;

Expand All @@ -158,7 +158,7 @@ internal virtual void InitializeFromAdjustmentRule(AdjustmentRule adjustmentRule
standardPeriodToSet.Id = string.Format(
"{0}/{1}",
standardPeriod.Id,
adjustmentRule.DateStart.Year);
adjustmentRule.DateSTart.ToString("yyyyMMdd"));
standardPeriodToSet.Name = standardPeriod.Name;
standardPeriodToSet.Bias = standardPeriod.Bias;
this.timeZoneDefinition.Periods.Add(standardPeriodToSet.Id, standardPeriodToSet);
Expand Down
2 changes: 1 addition & 1 deletion Core/EwsHttpWebRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public async Task<IEwsHttpWebResponse> GetResponse(CancellationToken token)
HttpResponseMessage response = null;
try
{
response = await _httpClient.SendAsync(message, token);
response = await _httpClient.SendAsync(message, HttpCompletionOption.ResponseHeadersRead., token);
}
catch(Exception exception)
{
Expand Down