Skip to content

fix: configuration actions #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
James-Baloyi merged 3 commits into from
Apr 1, 2025
Merged

fix: configuration actions #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06211ec
fix: configuration actions
czwe-01 Apr 1, 2025
2613ef7
Merge branch 'main' into thulasizwe/en/button-group
czwe-01 Apr 1, 2025
d0aaada
lodas
czwe-01 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shesha-reactjs/src/providers/appConfigurator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@
const result = auth && auth.anyOfPermissionsGranted([PERM_APP_CONFIGURATOR]);

return result;
}, [auth, auth?.isLoggedIn, auth?.state?.status]);

Check warning on line 67 in shesha-reactjs/src/providers/appConfigurator/index.tsx

View workflow job for this annotation

GitHub Actions / build-and-test 

React Hook useMemo has unnecessary dependencies: 'auth.isLoggedIn' and 'auth.state.status'. Either exclude them or remove the dependency array

useEffect(() => {
// sync headers
setHeaderValue(hasRights ? itemMode : 'live');
}, [itemMode, hasRights]);

Check warning on line 72 in shesha-reactjs/src/providers/appConfigurator/index.tsx

View workflow job for this annotation

GitHub Actions / build-and-test 

React Hook useEffect has a missing dependency: 'setHeaderValue'. Either include it or remove the dependency array

const result: IUseAppConfiguratorSettingsResponse = hasRights
? {
Expand Down Expand Up @@ -127,7 +127,7 @@

useConfigurableAction<IHasConfigurableItemId>(
{
name: 'Set item ready',
name: 'Set Item Ready',
owner: actionsOwner,
ownerUid: SheshaActionOwners.ConfigurationFramework,
hasArguments: true,
Expand Down Expand Up @@ -155,7 +155,7 @@

useConfigurableAction<IHasConfigurableItemId>(
{
name: 'Publish item',
name: 'Publish Item',
owner: actionsOwner,
ownerUid: SheshaActionOwners.ConfigurationFramework,
hasArguments: true,
Expand Down Expand Up @@ -205,7 +205,7 @@
if (state.mode === 'edit') {
document.body.classList.add(...classes);
}
}, [state.mode]);

Check warning on line 208 in shesha-reactjs/src/providers/appConfigurator/index.tsx

View workflow job for this annotation

GitHub Actions / build-and-test 

React Hook useEffect has a missing dependency: 'styles.shaAppEditMode'. Either include it or remove the dependency array

/* NEW_ACTION_DECLARATION_GOES_HERE */

Expand Down
2 changes: 1 addition & 1 deletion ...oviders/dynamicActions/implementations/dataSourceDynamicMenu/urlDynamicMenuItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const UrlActions: FC<PropsWithChildren<IWorkflowInstanceStartActionsProps
return (
<DynamicActionsProvider
id="Url"
name="URL"
name="Url"
useEvaluator={useUrlActions}
hasArguments={true}
settingsFormMarkup={settingsMarkup}
Expand Down
2 changes: 1 addition & 1 deletion shesha-reactjs/src/providers/dynamicActions/implementations/entityCrudActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const EntityCrudActions: FC<PropsWithChildren<IEntityCrudActionsProps>> =
return (
<DynamicActionsProvider
id='entity-crud'
name='CRUD actions'
name='CRUD Actions'
renderingHoc={entityActionsHoc}
useEvaluator={useEntityCrudActions}
>
Expand Down
6 changes: 3 additions & 3 deletions shesha-reactjs/src/providers/dynamicModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const DynamicModalProvider: FC<PropsWithChildren<IDynamicModalProviderProps>> =

useConfigurableAction<IShowConfirmationArguments>(
{
name: 'Show confirmation dialog',
name: 'Show Confirmation Dialog',
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
hasArguments: true,
Expand Down Expand Up @@ -71,7 +71,7 @@ const DynamicModalProvider: FC<PropsWithChildren<IDynamicModalProviderProps>> =

useConfigurableAction<IShowModalActionArguments>(
{
name: 'Show dialog',
name: 'Show Dialog',
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
hasArguments: true,
Expand Down Expand Up @@ -155,7 +155,7 @@ const DynamicModalProvider: FC<PropsWithChildren<IDynamicModalProviderProps>> =
//#region Close the latest Dialog
useConfigurableAction<ICloseModalActionArguments>(
{
name: 'Close dialog',
name: 'Close Dialog',
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
hasArguments: true,
Expand Down
4 changes: 2 additions & 2 deletions shesha-reactjs/src/providers/form/configurableActions/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const useShaFormActions = ({ name, isActionsOwner, shaForm }: UseShaFormA

useConfigurableAction(
{
name: 'Start edit',
name: 'Start Edit',
owner: name,
ownerUid: actionsOwnerUid,
hasArguments: false,
Expand All @@ -34,7 +34,7 @@ export const useShaFormActions = ({ name, isActionsOwner, shaForm }: UseShaFormA

useConfigurableAction(
{
name: 'Cancel edit',
name: 'Cancel Edit',
owner: name,
ownerUid: actionsOwnerUid,
hasArguments: false,
Expand Down
2 changes: 1 addition & 1 deletion shesha-reactjs/src/providers/sheshaApplication/configurable-actions/api-call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const useApiCallAction = () => {
isPermament: true,
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
name: 'API call',
name: 'API Call',
hasArguments: true,
argumentsFormMarkup: apiCallArgumentsForm,
executer: (actionArgs, _context) => {
Expand Down
2 changes: 1 addition & 1 deletion ...actjs/src/providers/sheshaApplication/configurable-actions/configuration-items-import.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { useAppConfiguratorState, useDynamicModals } from '@/providers';
import { useConfigurableAction } from '@/providers/configurableActionsDispatcher';
import { ValidationErrors } from '@/components';

const actionsOwner = 'Configuration items';
const actionsOwner = 'Configuration Items';

interface IConfigurationItemsExportFooterProps {
hideModal: () => void;
Expand Down
2 changes: 1 addition & 1 deletion shesha-reactjs/src/providers/sheshaApplication/configurable-actions/execute-script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const useExecuteScriptAction = () => {
isPermament: true,
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
name: 'Execute script',
name: 'Execute Script',
hasArguments: true,
argumentsFormMarkup: (formArgs) => executeScriptArgumentsForm(formArgs),
executer: (actionArgs, context) => {
Expand Down
2 changes: 1 addition & 1 deletion shesha-reactjs/src/providers/sheshaApplication/configurable-actions/show-message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const useShowMessageAction = () => {
isPermament: true,
owner: 'Common',
ownerUid: SheshaActionOwners.Common,
name: 'Show message',
name: 'Show Message',
hasArguments: true,
argumentsFormMarkup: showMessageArgumentsForm,
executer: (actionArgs, _context) => {
Expand Down
Loading