sorting editor updates on local items

[teboho]

#2977

Fixing this issue
https://jam.dev/c/42df9ebb-d728-42e2-bc35-cc02584514f5

Summary by CodeRabbit

• Refactor
  • Improved the organization of the settings form by grouping related options into single rows, making the form layout more streamlined and visually cohesive. No changes to input functionality or behavior.

[coderabbitai]

Walkthrough

The changes refactor the internal structure of the settings form configuration in the data table designer component. Specifically, they consolidate certain settings inputs into grouped rows using .addSettingsInputRow, replacing separate .addSettingsInput calls. In the "Common" tab, the "Disable Refresh Data" and "Hide" options are now grouped into a single row. Similarly, in the "Data" tab, the "Data Fetching Mode" dropdown is merged into the same row as the "Default Page Size" dropdown. The logic, properties, and visibility conditions of the inputs remain unchanged.

Changes

File(s)	Change Summary
shesha-reactjs/src/designer-components/dataTable/tableContext/settingsForm.ts	Refactored settings form configuration by grouping related inputs into .addSettingsInputRow calls instead of separate .addSettingsInput calls. Added readOnly properties to grouped inputs and rows. No changes to input logic or function signatures.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsForm
    User->>SettingsForm: Open settings form
    SettingsForm->>SettingsForm: Render grouped input rows (e.g., "Disable Refresh Data" + "Hide" in one row)
    SettingsForm->>User: Display updated form layout with grouped settings

Loading

Possibly related PRs

• some side by side properties reorder for entity reference #3162: Both PRs refactor settings form configurations by consolidating separate .addSettingsInput calls into grouped .addSettingsInputRow calls containing multiple inputs, improving input grouping and structure within their respective components.

Suggested reviewers

• James-Baloyi

Poem

In rows we now unite,
Settings side by side, just right.
Toggles and dropdowns, grouped anew,
A tidier form for all to view.
With code refactored, clean and neat,
The rabbit hops—organization’s treat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf7f4f and 059c2ed.

📒 Files selected for processing (1)

• shesha-reactjs/src/designer-components/dataTable/tableContext/settingsForm.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• shesha-reactjs/src/designer-components/dataTable/tableContext/settingsForm.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-attempt

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[IvanIlyichev]

Hi @teboho. List editor is used by different components including lists with groups. Please make sure that your changes work in all of them. One of example of issues reintroduiced by your changes: #1690
There were some reasons for mutability. Ideally it should be immutable but it requires more changes

[teboho]

Hi @IvanIlyichev thank you for the feedback,I will take further look

[teboho]

Hi @IvanIlyichev , I saw that the TableViewSelector currently on functional is already not working correctly which means that already on main something is wrong with it, I've alerted @Tshepo1103-lab about it, while I did revert the changes this PR was proposing I still need to test if trying to use those changes still affects the TableViewSelector negatively?

---

I will reapply the changes once TableViewSelector works again and test all the places where the list editor is used to see if they still work as in v43