Tshepo/f/readonly

[Tshepo1103-lab]

Summary by CodeRabbit

• Refactor
  • Streamlined many settings forms to remove unnecessary edit restrictions, ensuring input fields are more consistently editable. Users may experience a smoother and more flexible interaction when updating configurations across the application.

[coderabbitai]

Walkthrough

The changes remove the readOnly property from numerous settings input configurations across various files. The modifications affect functions such as getGroupSettings and getSettings in components, designer-components, and providers, eliminating the dynamic evaluation of the read-only state based on data?.readOnly. An interface update now makes readOnly optional. No new functionality or major control-flow adjustments were introduced.

Changes

File(s)	Change Summary
shesha-reactjs/src/components/[buttonGroupConfigurator/, configurableSidebarMenu/, formDesigner/*]	Removed readOnly property from input configuration methods in functions like getGroupSettings and getSettings, eliminating conditional editability logic.
shesha-reactjs/src/designer-components/[**/settingsForm.ts, _settings/utils/*, settingsInputRow/index.tsx, etc.]	Bulk removal of readOnly properties from settings input rows across many UI components; updated IInputRowProps to make readOnly optional.
shesha-reactjs/src/providers/[dynamicActions/, dynamicModal/, shaRouting/, sheshaApplication/]	Eliminated explicit readOnly attributes in settings configurations for dynamic menu items, modal confirmation forms, routing actions, and API-call settings.

Possibly related PRs

• James/feat/subform #3112: The changes in the main PR and the retrieved PR are related as both involve modifications to the handling of the readOnly property within settings input configurations, specifically in the context of the getSettings function, indicating a shift in how user interactions are managed.
• Tabbed properties for side menu #3106: The changes in the main PR, which involve the removal of the readOnly property from various settings input configurations, are related to the retrieved PR as both involve modifications to the getGroupSettings and getItemSettings functions, specifically regarding the handling of the readOnly state for settings inputs.

Suggested reviewers

• James-Baloyi

Poem

I'm a rabbit with ears so long,
Hopping through code with a joyful song,
Removing readOnly as I merrily roam,
Now every input feels free to call home.
A little hop here and a skip there,
My code garden blooms in open air!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19fd3cf and 55ffb86.

📒 Files selected for processing (1)

• shesha-reactjs/src/designer-components/drawer/settingsForm.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• shesha-reactjs/src/designer-components/drawer/settingsForm.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-attempt

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.