James/f/datalist

[James-Baloyi]

Summary by CodeRabbit

• New Features

  • Added "Create Form Type" field and "Dialog Width (%)" dropdown in the settings, with conditional visibility based on user selections.
  • Introduced a "Show Border" switch in the appearance settings, visible when orientation is set to "wrap".

• Bug Fixes

  • Updated the label for the form selection from "Modal Form" to "Create Form".

• Refactor

  • Removed the "onListItemSaveSuccessAction" event action configurator from the events tab.

[coderabbitai]

Walkthrough

The changes update the data list settings form by renaming a label, adding new conditional input fields under the "Can Add Inline" panel, introducing a "Show Border" switch in the appearance tab, and removing an event action configurator. No exported or public function signatures were altered.

Changes

File(s)	Change Summary
shesha-reactjs/src/designer-components/dataList/settingsForm.ts	- Changed "Modal Form" label to "Create Form" for formId property. - Added conditional "Create Form Type" and "Dialog Width (%)" inputs under "Can Add Inline". - Removed onListItemSaveSuccessAction configurator. - Added "Show Border" switch in appearance tab, shown when orientation is "wrap".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsForm
    participant UI

    User->>SettingsForm: Open Data List Settings
    SettingsForm->>UI: Render settings fields
    alt Can Add Inline enabled
        UI->>User: Show "Create Form Type" and "Dialog Width (%)" inputs
    end
    alt Orientation is "wrap"
        UI->>User: Show "Show Border" switch
    end
    Note over SettingsForm: "onListItemSaveSuccessAction" configurator removed

Loading

Possibly related PRs

• James/en/datalist #3113: Both PRs modify the getSettings function in settingsForm.ts to restructure and add conditional UI elements for data list settings, indicating a direct relation in their changes to the same configuration logic.

Poem

In the garden of settings, new fields sprout and grow,
"Create Form" blooms where "Modal" used to show.
Inline and borders, options now align,
Old actions pruned, new switches shine.
A rabbit hops by, delighted to see—
The form now fits more snug as can be!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 786a753 and 1459c64.

📒 Files selected for processing (1)

• shesha-reactjs/src/designer-components/dataList/settingsForm.ts (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-attempt

🔇 Additional comments (5)

shesha-reactjs/src/designer-components/dataList/settingsForm.ts (5)

130-130: Improved label clarity.

Renaming "Modal Form" to "Create Form" provides better clarity about the purpose of this field.

---

245-265: Good addition of conditional form type selection.

The new "Create Form Type" field appears only when formSelectionMode is "view", which provides a consistent UI experience and additional configuration options when needed.

---

279-299: Enhanced dialog customization with width options.

The new dialog width dropdown provides useful preset sizes (Small, Medium, Large, Custom), which will help users configure their dialogs more easily without having to know specific percentage values.

---

550-562: Good UI enhancement with conditional border control.

Adding the "Show Border" switch for cards when orientation is "wrap" gives users more control over the visual appearance of their data lists. This is a valuable addition that enhances the component's customizability.

---

423-447: Verify event configurator functionality is preserved.

I notice the AI summary mentioned the removal of an event action configurator for onListItemSaveSuccessAction, but this configurator still appears to be present in the code. Please verify that this is intentional and that the functionality is working as expected.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.