#3320 switch sourcelink to private#3321
#3320 switch sourcelink to private#3321thompson-tomo wants to merge 5 commits intoshesha-io:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughCentralized the Microsoft.SourceLink.GitHub package by adding it to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shesha-core/src/Directory.Build.props`:
- Around line 14-19: The XML has an unclosed <ItemGroup> that wraps the
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0"> entry;
fix by adding a matching </ItemGroup> closing tag after the PackageReference
block so the <ItemGroup> is properly terminated and the XML can parse correctly
(ensure the closing </ItemGroup> is placed before any subsequent tags/comments).
- Around line 15-18: Directory.Build.props already declares PackageReference
Include="Microsoft.SourceLink.GitHub" Version="8.0.0", so remove the duplicate
PackageReference entries from Shesha.Web.Host.csproj and Shesha.Tests.csproj:
locate the <PackageReference Include="Microsoft.SourceLink.GitHub"> (in
Shesha.Web.Host.csproj) and the <PackageReference
Include="Microsoft.SourceLink.GitHub" Version="8.0.0"> (in Shesha.Tests.csproj)
and delete those nodes so the projects inherit the centralized reference from
Directory.Build.props, ensuring consistent versioning and avoiding conflicts.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 35b3ce4c-f00b-407f-b169-4267f8553cbc
📒 Files selected for processing (3)
shesha-core/src/Directory.Build.propsshesha-core/src/Shesha.Application/Shesha.Application.csprojshesha-core/src/Shesha.Core/Shesha.Core.csproj
💤 Files with no reviewable changes (1)
- shesha-core/src/Shesha.Application/Shesha.Application.csproj
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find any remaining Microsoft.SourceLink.GitHub references in project files
echo "=== Searching for Microsoft.SourceLink.GitHub references in .csproj files ==="
rg -n "Microsoft\.SourceLink\.GitHub" --glob "*.csproj"Repository: shesha-io/shesha-framework
Length of output: 1488
Remove duplicate Microsoft.SourceLink.GitHub package references from project files.
Projects under shesha-core/src/ inherit from this Directory.Build.props. Remove the duplicate reference from:
shesha-core/src/Shesha.Web.Host/Shesha.Web.Host.csproj(line 50, no version)
Additionally, remove the duplicate from:
shesha-core/test/Shesha.Tests/Shesha.Tests.csproj(line 101, version 8.0.0)
Centralizing this dependency in Directory.Build.props ensures consistent versioning across the solution and avoids package resolution conflicts.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@shesha-core/src/Directory.Build.props` around lines 15 - 18,
Directory.Build.props already declares PackageReference
Include="Microsoft.SourceLink.GitHub" Version="8.0.0", so remove the duplicate
PackageReference entries from Shesha.Web.Host.csproj and Shesha.Tests.csproj:
locate the <PackageReference Include="Microsoft.SourceLink.GitHub"> (in
Shesha.Web.Host.csproj) and the <PackageReference
Include="Microsoft.SourceLink.GitHub" Version="8.0.0"> (in Shesha.Tests.csproj)
and delete those nodes so the projects inherit the centralized reference from
Directory.Build.props, ensuring consistent versioning and avoiding conflicts.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shesha-core/src/Directory.Build.props`:
- Around line 14-19: Remove the redundant Microsoft.SourceLink.GitHub
PackageReference from the Shesha.Web.Host.csproj file: since
shesha-core/src/Directory.Build.props already defines <PackageReference
Include="Microsoft.SourceLink.GitHub" Version="8.0.0"> for projects under
src/**, delete the corresponding PackageReference block in
Shesha.Web.Host.csproj (the direct reference around line 50) so the project
inherits the centralized setting; after removal, run a build to confirm no other
duplicate SourceLink references remain and that SourceLink is still applied via
Directory.Build.props.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b9c67325-cef6-47cd-8e88-b622c8aa9b8d
📒 Files selected for processing (1)
shesha-core/src/Directory.Build.props
1 participant
Closes #3320
Summary by CodeRabbit