fix: search for values data source

[czwe-01]

#3278

Summary by CodeRabbit

• New Features

  • Enabled case-insensitive search within dropdowns, allowing users to filter options as they type.

• Style

  • Updated dropdown tag styles to center-align content and text for a more consistent appearance.

• Refactor

  • Improved dropdown component flexibility by allowing custom filtering behavior to be passed in.

• Bug Fixes

  • Refined number field input handling to better distinguish undefined values from other falsy inputs.

[coderabbitai]

Walkthrough

A customizable case-insensitive filtering function was introduced and integrated into dropdown components, enabling search functionality. The GenericRefListDropDown now accepts a filterOption prop, and related dropdown components explicitly enable searching. Additionally, dropdown tag styling was updated to enforce centered alignment both in code and default styles. The NumberFieldComponent refined its input change handler condition to strictly check for undefined.

Changes

File(s)	Change Summary
shesha-reactjs/src/components/dropdown/dropdown.tsx	Added a customizable, case-insensitive filterOption for searching; passed it to dropdown/select components; updated key prop usage.
shesha-reactjs/src/components/refListDropDown/genericRefListDropDown.tsx	Added filterOption prop to component and passed it to internal Select, replacing the previous hardcoded filter.
shesha-reactjs/src/designer-components/dropdown/index.tsx	Updated tag styling to use alignContent: 'center' instead of dynamic justification.
shesha-reactjs/src/designer-components/dropdown/utils.ts	Added align: 'center' to the font object in defaultTagStyles.
shesha-reactjs/src/designer-components/numberField/numberField.tsx	Changed condition in onChangeInternal handler to explicitly check val === undefined instead of falsy check.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Dropdown
    participant GenericRefListDropDown
    participant Select

    User->>Dropdown: Types in search input
    Dropdown->>GenericRefListDropDown: Passes filterOption and showSearch
    GenericRefListDropDown->>Select: Passes filterOption and showSearch
    Select->>Dropdown: Calls filterOption for each option
    Dropdown->>Select: Returns match result (case-insensitive)
    Select-->>User: Displays filtered options

Loading

Possibly related PRs

• fix: numberField throwing string error messages #3422: Refinements to the NumberFieldComponent's onChangeInternal handler logic and input parsing, related to the condition change in this PR.

Suggested reviewers

• James-Baloyi

Poem

In dropdown fields where options grow,
A rabbit hops, with search in tow.
Now filters match both big and small,
Case-insensitive, found by all!
Tags align and center, neat—
Dropdown magic is complete.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f42af4 and 37bd62e.

📒 Files selected for processing (1)

• shesha-reactjs/src/designer-components/numberField/numberField.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: teboho
PR: shesha-io/shesha-framework#3461
File: shesha-reactjs/src/designer-components/charts/chartControl.tsx:51-51
Timestamp: 2025-06-26T20:00:58.574Z
Learning: In shesha-reactjs chart components (ChartControl), filters are intentionally passed as props rather than obtained from context. This allows the query builder and other external components to dynamically update filters. The pattern is: most chart configuration comes from useChartDataStateContext(), but filters are passed as props from the chart factories (bar.tsx, line.tsx, pie.tsx, polarArea.tsx) for dynamic updates.

shesha-reactjs/src/designer-components/numberField/numberField.tsx (1)

Learnt from: teboho
PR: shesha-io/shesha-framework#3397
File: shesha-reactjs/src/designer-components/charts/bar.tsx:49-52
Timestamp: 2025-06-12T16:55:57.638Z
Learning: For the chart components’ migrators (e.g., BarChartComponent in shesha-reactjs/src/designer-components/charts/bar.tsx), the version 5 step intentionally spreads `{ ...prev, ...defaultConfigFiller }` so that values from `defaultConfigFiller` override any existing properties in `prev`. This reset to new defaults is by design and should not be flagged as an issue.

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-attempt

🔇 Additional comments (1)

shesha-reactjs/src/designer-components/numberField/numberField.tsx (1)

81-81: Good improvement for handling valid falsy values.

The change from !val to val === undefined correctly preserves valid falsy values like 0, which is a legitimate number input that should not be converted to undefined. This ensures that users can properly enter and work with zero values.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.