refactor: enabled @typescript-eslint/explicit-module-boundary-types ESlint rule, fixed code#3967
Merged
IvanIlyichev merged 1 commit intomainfrom Oct 12, 2025
Merged
refactor: enabled @typescript-eslint/explicit-module-boundary-types ESlint rule, fixed code#3967IvanIlyichev merged 1 commit intomainfrom
IvanIlyichev merged 1 commit intomainfrom
Conversation
…Slint rule, fixed code
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughBroad TypeScript tightening replaces many any parameters with object or unknown across UI settings builders, utilities, hooks, providers, and type guards. One helper is removed, several guards are added, and a few behaviors change: column settings builder refactor, query builder date/time widgets, gqlLoader.canLoadData logic, and minor API surface adjustments. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as UI Component
participant F as useFormEvaluatedFilter
participant P as ObservableProxy
participant C as Context
participant E as Evaluator
U->>F: args, additionalData (object)
alt has additionalData
F->>P: setAdditionalData(additionalData)
end
F->>C: build context
C->>E: evaluate(filterTemplate, context)
E-->>F: filter string
F-->>U: evaluated filter
note right of F: additionalData type narrowed to object
sequenceDiagram
autonumber
actor D as Designer
participant S as getColumnSettings(data?: object)
participant B as Builder
D->>S: open column settings
S->>S: dataType = data?.type
S->>B: add Common tab + columnType
alt dataType == "Data"
S->>B: show Data Settings container
else dataType == "Form"
S->>B: show Form Settings container
else
S->>B: show generic Display/Action panels
end
B-->>D: markup JSON
note over S,B: Visibility rules depend on computed dataType
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit