Skip to content

Button ReadOnly property#4100

Merged
James-Baloyi merged 2 commits intoshesha-io:mainfrom
czwe-01:thulasizwe/0.45/fix/3925
Nov 3, 2025
Merged

Button ReadOnly property#4100
James-Baloyi merged 2 commits intoshesha-io:mainfrom
czwe-01:thulasizwe/0.45/fix/3925

Conversation

@czwe-01
Copy link
Copy Markdown
Collaborator

@czwe-01 czwe-01 commented Oct 30, 2025

Fix readonly mode on button group configurator

Summary by CodeRabbit

  • Bug Fixes
    • Read-only buttons are now genuinely disabled and non-interactive (improves accessibility).
    • Visual cursor treatment adjusted so read-only buttons no longer force a "not-allowed" cursor, aligning pointer behavior with disabled state.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 30, 2025

Walkthrough

Button component in buttonGroupItem.tsx now receives disabled={readOnly} and the inline cursor: not-allowed override has been removed; no other rendering or exported signatures were changed.

Changes

Cohort / File(s) Change Summary
Button disabled state handling
shesha-reactjs/src/components/buttonGroupConfigurator/buttonGroupItem.tsx
Added disabled={readOnly} prop to the Button component and removed the conditional inline cursor: not-allowed style; other styling logic and rendering unchanged

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-line prop addition and removal of an inline style.
  • Review attention: ensure no visual regressions where cursor behavior was relied upon.

Possibly related PRs

Suggested reviewers

  • James-Baloyi

Poem

🐇 A tiny change, a simple tweak,
The button rests when reads-only speak.
No pointer fuss, just honest state,
Quiet clicks now patiently wait. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Button ReadOnly property" is directly related to the changeset, which implements the readOnly property functionality for the Button component in the button group configurator. The title specifically identifies both the component being modified (Button) and the property being implemented (ReadOnly property), making it clear and not vague. While the title could be more descriptive about what the fix accomplishes (disabling the button and adjusting styles when in readonly mode), it sufficiently conveys the core subject of the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82e9d33 and efbca38.

📒 Files selected for processing (1)
  • shesha-reactjs/src/components/buttonGroupConfigurator/buttonGroupItem.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • shesha-reactjs/src/components/buttonGroupConfigurator/buttonGroupItem.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@czwe-01 czwe-01 changed the title thulasizwe/f/3925 Button ReadOnly property Oct 30, 2025
@czwe-01 czwe-01 requested a review from James-Baloyi October 30, 2025 11:22
@James-Baloyi James-Baloyi merged commit e31394f into shesha-io:main Nov 3, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants