Skip to content

Thulasizwe/b/75986 #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
James-Baloyi merged 5 commits into from
Dec 8, 2025
Merged

Thulasizwe/b/75986 #4328

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccb5cea
rm unnecesaary padding that is causing scroll
czwe-01 Dec 8, 2025
5d68677
Refactor ReadOnlyDisplayFormItem styles and InputField component for …
czwe-01 Dec 8, 2025
7e090f0
Improve code formatting in ReadOnlyDisplayFormItem and InputField com…
czwe-01 Dec 8, 2025
560c41b
Enhance useStyles in ReadOnlyDisplayFormItem by adding optional textA…
czwe-01 Dec 8, 2025
8393950
Refactor UseStylesParams interface in ReadOnlyDisplayFormItem styles …
czwe-01 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shesha-reactjs/src/components/readOnlyDisplayFormItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const ReadOnlyDisplayFormItem: FC<IReadOnlyDisplayFormItemProps> = (props
return dropdownDisplayMode === 'raw'
? <InputField style={style} value={values?.join(', ')} />
: (
<div style={{ padding: '0px 4px', ...style, display: 'flex', flexWrap: 'wrap', alignItems: 'center', gap: 8, justifyContent: style?.textAlign }}>
<div className={styles.wrapper} style={{ ...style }}>
{value?.map(({ label, color, icon, value, description }) => {
return (
<ReflistTag
Expand Down
6 changes: 3 additions & 3 deletions shesha-reactjs/src/components/readOnlyDisplayFormItem/inputField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ interface IInputFieldProps {
}

function InputField({ value, style, children }: IInputFieldProps): JSX.Element {
const { styles } = useStyles();
const { styles } = useStyles({ textAlign: style?.textAlign || 'left' });

const { fontSize, fontWeight, color, fontFamily, textAlign, height } = style || {};
const { fontSize, fontWeight, color, fontFamily, height } = style || {};

return value || children ? (
<div style={{ padding: '4px', ...style, height: height, display: 'flex', alignItems: 'center', justifyContent: textAlign }}>
<div style={{ ...style }} className={styles.wrapper}>
<div className={styles.inputField} style={{ fontSize, fontWeight, color, fontFamily, whiteSpace: height === 'auto' ? 'pre-wrap' : 'nowrap', flex: 'none' }}>{value || children}</div>
</div>
) : null;
Expand Down
21 changes: 19 additions & 2 deletions shesha-reactjs/src/components/readOnlyDisplayFormItem/styles/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import { createStyles, sheshaStyles, getTextHoverEffects } from '@/styles';
import { CSSProperties } from 'react';

interface UseStylesParams {
textAlign?: CSSProperties['textAlign'];
};

export const useStyles = createStyles(({ css, cx, prefixCls, token }, params: UseStylesParams) => {
const { textAlign } = params;

export const useStyles = createStyles(({ css, cx, prefixCls, token }) => {
const readOnlyModeToggler = "read-only-mode-toggler";
const readOnlyDisplayFormItem = cx("read-only-display-form-item", css`
width: 100%;
Expand Down Expand Up @@ -56,9 +62,20 @@ export const useStyles = createStyles(({ css, cx, prefixCls, token }) => {
// white-space: nowrap;
`;

const wrapper = css`
display: flex;
flex-wrap: wrap;
align-items: center;
gap: 8px;
padding: 4px;
box-sizing: border-box;
justify-content: ${textAlign === 'center' ? 'center' : textAlign === 'right' ? 'flex-end' : 'flex-start'};
`;

return {
readOnlyDisplayFormItem,
readOnlyModeToggler,
inputField,
wrapper,
};
});
});