Skip to content

Fix/1521/excel export ignore hidden columns #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EthanJappie wants to merge 4 commits into
base: releases/0.44
Choose a base branch
from
Open

Fix/1521/excel export ignore hidden columns #4363

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483bfcf
#1521 Update connection string for docket container
EthanJappie Dec 10, 2025
8035e54
#1521 Exclude hidden columns from dataTable export
EthanJappie Dec 10, 2025
19ace4a
#1521 Revert changed connection string
EthanJappie Dec 13, 2025
d011522
#1521 Exclude id from export
EthanJappie Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions shesha-reactjs/src/providers/dataTable/repository/backendRepository.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,9 @@ const createRepository = (args: ICreateBackendRepositoryArgs): IBackendRepositor

const exportToExcel = (payload: IGetListDataPayload): Promise<void> => {
let excelColumns = payload.columns
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Use const instead of let for immutable variable.

The excelColumns variable is never reassigned, so it should be declared with const to prevent accidental mutations and improve code clarity.

Apply this diff:

-    let excelColumns = payload.columns
+    const excelColumns = payload.columns
         .filter(c => c.isVisible)
         .map<IExcelColumn>(c => ({ propertyName: c.propertyName, label: c.caption }));
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
let excelColumns = payload.columns
const excelColumns = payload.columns
.filter(c => c.isVisible)
.map<IExcelColumn>(c => ({ propertyName: c.propertyName, label: c.caption }));
🤖 Prompt for AI Agents 
In shesha-reactjs/src/providers/dataTable/repository/backendRepository.tsx
around line 258, the variable declaration uses "let excelColumns =
payload.columns" but excelColumns is never reassigned; change the declaration to
"const excelColumns = payload.columns" to make it immutable and prevent
accidental reassignments, leaving the rest of the code unchanged.

.filter(c => c.isVisible)
.map<IExcelColumn>(c => ({ propertyName: c.propertyName, label: c.caption }));

if (excelColumns.findIndex(c => c.propertyName === 'id') === -1) {
excelColumns = [{ propertyName: 'id', label: 'Id' }, ...excelColumns];
}

const getDataPayload = convertPayload(payload);

const excelPayload: IExportExcelPayload = {
Expand Down